Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify list log entries example documentation #740

Merged
merged 4 commits into from Nov 12, 2021
Merged

Conversation

minherz
Copy link
Contributor

@minherz minherz commented Nov 10, 2021

provide the working example to list log entries including going through multiple pages.
remove the reference to the unmaintained code samples in the google-cloud-java repository

Fixes #648

remove reference to unmanaged code in google-cloud-java.
@minherz minherz requested review from a team as code owners November 10, 2021 17:50
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 10, 2021
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Nov 10, 2021
Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@simonz130 simonz130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this sample visible in our docs?

.readme-partials.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@minherz minherz merged commit 790fb1a into main Nov 12, 2021
@minherz minherz deleted the minherz/648 branch November 12, 2021 06:40
@minherz
Copy link
Contributor Author

minherz commented Nov 12, 2021

Is this sample visible in our docs?

AFAIK the devrel site incorporates the README in a couple of places. The public documentation about Cloud logging use snippets as examples instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloud-logging entry iteration example broken, fails if more than 1 page.
3 participants