New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Extend a set of options in WriteOption to allow defining the log location as custom project, folder, organization or billing account #727
Conversation
…g location as custom project, folder, organization or billing account
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We recommend to minimize the scope of changes in order to speed up and simplify the reviewing process. It reduces a cognitive load of the reviewer and helps avoiding mistakes.
[edited] For the next time, please split changes into multiple PRs. In this PR we shall finish reviewing the changes related to the write interface and then will do modifications to LoggingHandler
and LoggingHandlerTest
, since the latter changes are not directly related to the PR's description and the linked issue(s).
google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingImplTest.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingImplTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, have a look into comments for changes in the LoggingImplTest.java
google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingImplTest.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingImplTest.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingImplTest.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingImplTest.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingImplTest.java
Show resolved
Hide resolved
google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingImplTest.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Feel free to ignore or apply the comment about request
variable name.
Thanks! |
Exposed an ability to set logs destination in WriteOption and added an ability to customize log destination in LoggingHandler
Fixes #684 ☕️