Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Cloud Run Monitored Resource #71

Closed
meltsufin opened this issue Jan 14, 2020 · 1 comment · Fixed by #78
Closed

Support Cloud Run Monitored Resource #71

meltsufin opened this issue Jan 14, 2020 · 1 comment · Fixed by #78
Assignees
@chingor13
Labels
api: logging Issues related to the googleapis/java-logging API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@meltsufin
Copy link
Member

Is your feature request related to a problem? Please describe.

Spring Cloud GCP Logging does not work with Cloud Run. The logs end up in the "Global" channel rather than the one for Cloud Run.

Describe the solution you'd like

The Cloud Run resource type cloud_run_revision should be automatically assigned to the log entries, similarly to how it's done for App Engine. See: MonitoredResourceUtil.

Describe alternatives you've considered

Using JSON-based logging on Cloud Run. It works better but has other issues like not supporting TRACE and WARN levels.

Additional context

Repro: https://github.com/meltsufin/cloud-run-helloworld
@meltsufin meltsufin changed the title Support Cloud Run Monitored Resrouce Support Cloud Run Monitored Resource Jan 14, 2020
@meltsufin meltsufin mentioned this issue Jan 14, 2020
Closed
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jan 15, 2020
@chingor13 chingor13 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jan 15, 2020
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Jan 15, 2020
@saturnism
Copy link

Ideally, there is a single public API call to retrieve/produce a MonitoredResource. This is a common library as oppose to only for logs.

meltsufin added a commit to meltsufin/java-logging that referenced this issue Jan 22, 2020
@meltsufin
Add support for Cloud Run monitored resource
11da859 
Fixes: googleapis#71.
@meltsufin meltsufin mentioned this issue Jan 22, 2020
Merged
meltsufin added a commit to meltsufin/java-logging that referenced this issue Jan 22, 2020
@meltsufin
fix: support for Cloud Run monitored resource
2bdd223 
Fixes: googleapis#71.
chingor13 pushed a commit that referenced this issue Jan 23, 2020
@meltsufin @chingor13
fix: support for Cloud Run monitored resource (#78)
b3c1b68 
* fix: support for Cloud Run monitored resource

Fixes: #71.

* add check for not k8s

* format
@google-cloud-label-sync google-cloud-label-sync bot added the api: logging Issues related to the googleapis/java-logging API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
api: logging Issues related to the googleapis/java-logging API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support for Cloud Run monitored resource meltsufin/java-logging
4 participants
@chingor13 @saturnism @meltsufin @yoshi-automation