Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Makes remaining LogBucket and LogViews methods public #336

Merged
merged 1 commit into from Nov 18, 2020

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/37d7837b-1bd3-4c03-9dca-513a772404ce/targets

  • To automatically regenerate this PR, check this box.

PiperOrigin-RevId: 342353190
Source-Link: googleapis/googleapis@be0bdf8

PiperOrigin-RevId: 342353190

Source-Author: Google APIs <noreply@google.com>
Source-Date: Fri Nov 13 15:44:35 2020 -0800
Source-Repo: googleapis/googleapis
Source-Sha: be0bdf86cd31aa7c1a7b30a9a2e9f2fd53ee3d91
Source-Link: googleapis/googleapis@be0bdf8
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • google-cloud-logging/src/main/java/com/google/cloud/logging/v2/ConfigClient.java
  • google-cloud-logging/src/main/java/com/google/cloud/logging/v2/ConfigSettings.java
  • google-cloud-logging/src/main/java/com/google/cloud/logging/v2/stub/ConfigServiceV2Stub.java
  • google-cloud-logging/src/main/java/com/google/cloud/logging/v2/stub/ConfigServiceV2StubSettings.java
  • google-cloud-logging/src/main/java/com/google/cloud/logging/v2/stub/GrpcConfigServiceV2Stub.java
  • google-cloud-logging/src/test/java/com/google/cloud/logging/v2/ConfigClientTest.java
  • google-cloud-logging/src/test/java/com/google/cloud/logging/v2/MockConfigServiceV2Impl.java
  • grpc-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ConfigServiceV2Grpc.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/GetBucketRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LifecycleState.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListBucketsRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListBucketsResponse.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LogBucket.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LogBucketOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LogMetric.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LogSink.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LogSinkOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LoggingConfigProto.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/UpdateBucketRequest.java
  • proto-google-cloud-logging-v2/src/main/proto/google/logging/v2/logging_config.proto
  • proto-google-cloud-logging-v2/src/main/proto/google/logging/v2/logging_metrics.proto

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2020
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Nov 14, 2020
@codecov
Copy link

codecov bot commented Nov 14, 2020

Codecov Report

Merging #336 (40194fb) into master (6f5c854) will increase coverage by 0.84%.
The diff coverage is 87.02%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #336      +/-   ##
============================================
+ Coverage     75.85%   76.69%   +0.84%     
- Complexity      640      673      +33     
============================================
  Files            44       44              
  Lines          3876     4192     +316     
  Branches        281      282       +1     
============================================
+ Hits           2940     3215     +275     
- Misses          772      812      +40     
- Partials        164      165       +1     
Impacted Files Coverage Δ Complexity Δ
...va/com/google/cloud/logging/v2/ConfigSettings.java 19.17% <0.00%> (-5.39%) 3.00 <0.00> (ø)
...gle/cloud/logging/v2/stub/ConfigServiceV2Stub.java 3.57% <0.00%> (-1.70%) 1.00 <0.00> (ø)
...d/logging/v2/stub/ConfigServiceV2StubSettings.java 83.89% <85.05%> (+0.37%) 34.00 <8.00> (+8.00)
...java/com/google/cloud/logging/v2/ConfigClient.java 53.08% <94.87%> (+5.71%) 74.00 <17.00> (+17.00)
...cloud/logging/v2/stub/GrpcConfigServiceV2Stub.java 97.42% <99.39%> (+0.95%) 30.00 <8.00> (+8.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f5c854...40194fb. Read the comment docs.

@simonz130 simonz130 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: process A process-related concern. May include testing, release, or the like. labels Nov 18, 2020
@simonz130 simonz130 merged commit f3472c2 into master Nov 18, 2020
@simonz130 simonz130 deleted the autosynth-googleapis branch November 18, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. cla: yes This human has signed the Contributor License Agreement. context: full priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants