Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for k8s_container resource type #207

Merged
merged 1 commit into from Dec 9, 2020

Conversation

suraj-qlogic
Copy link
Contributor

Fixes #206

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 6, 2020
@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #207 into master will decrease coverage by 0.19%.
The diff coverage is 23.80%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #207      +/-   ##
============================================
- Coverage     75.17%   74.98%   -0.20%     
  Complexity      593      593              
============================================
  Files            42       42              
  Lines          3646     3662      +16     
  Branches        251      253       +2     
============================================
+ Hits           2741     2746       +5     
- Misses          757      768      +11     
  Partials        148      148              
Impacted Files Coverage Δ Complexity Δ
...om/google/cloud/logging/MonitoredResourceUtil.java 38.46% <23.80%> (-0.91%) 5.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 039d9ba...77486c0. Read the comment docs.

elharo
elharo previously requested changes Aug 6, 2020
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm going to start drawing a hard line on these reviews. You can cc me if it helps, but they must be sent to a Google SWE on the appropriate team, cloud logging in this case.

Who is your point of contact on the logging team? If there is no such person we need to find somebody.

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that's @simonz130 for this PR? That's fine then, but please wait for his approval.

@suraj-qlogic
Copy link
Contributor Author

@simonz130 , @chingor13 PTAL

@suraj-qlogic suraj-qlogic self-assigned this Aug 13, 2020
@elharo elharo removed the request for review from chingor13 August 13, 2020 13:51
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but you should get an approval from @simonz130

@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Aug 21, 2020
@jeremyvdw
Copy link

Hi there, any chance of having this merged anytime soon? Thanks

@suraj-qlogic suraj-qlogic requested a review from a team November 9, 2020 12:25
@twistedpair
Copy link

Any chance of merging this soon? Fluentd records these values by default in GKE, but the GCP Logback appender doesn't because of this lack of metadata. This PR will fix that problem and be very helpful to our ability to query this log data.

@suraj-qlogic
Copy link
Contributor Author

@simonz130 ,gentle ping

@simonz130 simonz130 merged commit 233efcc into googleapis:master Dec 9, 2020
@simonz130 simonz130 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. cla: yes This human has signed the Contributor License Agreement. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for k8s_container resource type
5 participants