Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove usage of deprecated newInstance() method #203

Merged
merged 1 commit into from Aug 5, 2020
Merged

chore: remove usage of deprecated newInstance() method #203

merged 1 commit into from Aug 5, 2020

Conversation

suraj-qlogic
Copy link
Contributor

Fixes #202

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2020
@codecov
Copy link

codecov bot commented Jul 23, 2020 •
edited

Codecov Report

Merging #203 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #203   +/-   ##
=========================================
  Coverage     75.17%   75.17%           
  Complexity      593      593           
=========================================
  Files            42       42           
  Lines          3646     3646           
  Branches        251      251           
=========================================
  Hits           2741     2741           
  Misses          757      757           
  Partials        148      148
Impacted Files Coverage Δ Complexity Δ
...n/java/com/google/cloud/logging/LoggingConfig.java 54.16% <0.00%> (ø) 13.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cbf0af...f18e0bd. Read the comment docs.

@suraj-qlogic suraj-qlogic self-assigned this Jul 23, 2020
@suraj-qlogic
Copy link
Contributor Author

@chingor13 ,PTAL

@chingor13 chingor13 merged commit 039d9ba into googleapis:master Aug 5, 2020
@suraj-qlogic suraj-qlogic deleted the logging-remove-deprecate branch August 6, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

@elharo elharo elharo approved these changes

Assignees

@suraj-qlogic suraj-qlogic

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove warning newInstance() in java.lang.Class has been deprecated
3 participants
@suraj-qlogic @chingor13 @elharo