Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove Start/EndTime from LogSink, Metadata from LogEntry, implement multipattern resource names #174

Merged
merged 8 commits into from Jun 22, 2020

Conversation

yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Jun 5, 2020

Regenerates the Logging Client with the v2 Gapic configuration which includes multi-pattern resource names

NOTE if you are only using the hand-written layer, no changes should be necessary. The protobuf messages and generated clients are part of the public surface area so this is a major version bump.

Breaking proto message changes

  • Removes startTime and endTime fields from LogSink protobuf message
  • Removes metadata field from LogEntry protobuf message

Resource ames

Rather than providing an abstract base class for a resource name type, we provide a concrete base class which serves as the default resource name.

For example, we previously provided an abstract class LogName with concrete implementations of BillingLogName, FolderLogName, OrganizationLogName, and ProjectLogName from which you would pick one to use. Now LogName behaves like a ProjectLogName by default but can also be used to build all types - LogName.ofProjectLogName, LogName.ofBillingLogName, LogName.ofFolderLogName, LogName.ofOrganizationLogName. If you were using the LogNames.parse(String) static method, you can now use LogName.parse(String).

PiperOrigin-RevId: 313460921
Source-Link: googleapis/googleapis@c4e3701
PiperOrigin-RevId: 312088359
Source-Link: googleapis/googleapis@5a90d46
PiperOrigin-RevId: 309824146
Source-Link: googleapis/googleapis@e0f9d9e

BREAKING CHANGE:

  • If you only use com.google.cloud.logging classes (without the v2), you should not need to change any code.
  • Removes start/endTime from LogSink protobuf messages
  • Removes metadata from LogEntry protobuf messages
  • Removes old resource name types in favor of the new multi-pattern resource names

…ng documentai as an example. Depends on googleapis/gapic-generator-python#402

PiperOrigin-RevId: 309824146

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon May 4 15:06:44 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: e0f9d9e1f9de890db765be46f45ca8490723e3eb
Source-Link: googleapis/googleapis@e0f9d9e
Restores GAPIC v2 retry config overrides that were
mistakenly removed during migration.

PiperOrigin-RevId: 312088359

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon May 18 08:57:12 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 5a90d467aa65e7f038f87585e8fbb45d74475e7c
Source-Link: googleapis/googleapis@5a90d46
…sions - protobuf v3.12.1 - rules_go v0.23.0 - gazelle v0.21.0 - gapic-generator-go v0.14.1

PiperOrigin-RevId: 313460921

Source-Author: Google APIs <noreply@google.com>
Source-Date: Wed May 27 14:10:16 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: c4e37010d74071851ff24121f522e802231ac86e
Source-Link: googleapis/googleapis@c4e3701
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 5, 2020
@chingor13 chingor13 changed the title [CHANGE ME] Re-generated to pick up changes in the API or client library generator. feat!: remove Start/EndTime from LogSink, Metadata from LogEntry, implement multipattern resource names Jun 9, 2020
@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #174 into master will decrease coverage by 1.55%.
The diff coverage is 83.86%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #174      +/-   ##
============================================
- Coverage     76.73%   75.17%   -1.56%     
- Complexity      579      593      +14     
============================================
  Files            42       42              
  Lines          3426     3646     +220     
  Branches        237      251      +14     
============================================
+ Hits           2629     2741     +112     
- Misses          651      757     +106     
- Partials        146      148       +2     
Impacted Files Coverage Δ Complexity Δ
...java/com/google/cloud/logging/v2/ConfigClient.java 47.36% <ø> (-13.53%) 57.00 <0.00> (+8.00) ⬇️
...va/com/google/cloud/logging/v2/ConfigSettings.java 24.56% <0.00%> (-2.89%) 3.00 <0.00> (ø)
...a/com/google/cloud/logging/v2/MetricsSettings.java 37.83% <0.00%> (ø) 3.00 <0.00> (ø)
...gle/cloud/logging/v2/stub/ConfigServiceV2Stub.java 5.26% <0.00%> (-1.41%) 1.00 <0.00> (ø)
...le/cloud/logging/v2/stub/LoggingServiceV2Stub.java 11.11% <0.00%> (ø) 1.00 <0.00> (ø)
...le/cloud/logging/v2/stub/MetricsServiceV2Stub.java 14.28% <0.00%> (ø) 1.00 <0.00> (ø)
...a/com/google/cloud/logging/v2/LoggingSettings.java 42.10% <50.00%> (ø) 4.00 <0.00> (ø)
...ava/com/google/cloud/logging/v2/LoggingClient.java 64.92% <54.54%> (-4.68%) 21.00 <8.00> (ø)
...ava/com/google/cloud/logging/v2/MetricsClient.java 60.63% <62.50%> (ø) 23.00 <8.00> (ø)
...d/logging/v2/stub/ConfigServiceV2StubSettings.java 82.94% <84.28%> (-1.20%) 26.00 <6.00> (+3.00) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 288a894...ff4ccc1. Read the comment docs.

@chingor13 chingor13 requested review from elharo, kolea2 and a team June 10, 2020 21:23
@chingor13 chingor13 merged commit d3d2370 into master Jun 22, 2020
@chingor13 chingor13 deleted the autosynth branch June 22, 2020 21:34
@release-please release-please bot mentioned this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. context: full
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants