From 62e783839b9a7c29a05bfeac55189bd8ea1bdfd6 Mon Sep 17 00:00:00 2001 From: losalex <90795544+losalex@users.noreply.github.com> Date: Fri, 10 Dec 2021 22:15:43 -0800 Subject: [PATCH] fix: Rename LogDestinationName.getId() to LogDestinationName.getDestinationId() (#797) --- .../java/com/google/cloud/logging/LogDestinationName.java | 2 +- .../test/java/com/google/cloud/logging/LoggingTest.java | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/google-cloud-logging/src/main/java/com/google/cloud/logging/LogDestinationName.java b/google-cloud-logging/src/main/java/com/google/cloud/logging/LogDestinationName.java index 3472afb93..dcf6a12cc 100644 --- a/google-cloud-logging/src/main/java/com/google/cloud/logging/LogDestinationName.java +++ b/google-cloud-logging/src/main/java/com/google/cloud/logging/LogDestinationName.java @@ -110,7 +110,7 @@ public LogName toLogName(String logId) { } /** Returns ID value associated with {@code LogDestinationName} object */ - public String getId() { + public String getDestinationId() { return getValue().toString(); } diff --git a/google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingTest.java b/google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingTest.java index 4bd485ea7..2b7dc0f0e 100644 --- a/google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingTest.java +++ b/google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingTest.java @@ -117,24 +117,24 @@ public void testWriteOptionWithDestination() { LogDestinationName resource = (LogDestinationName) writeOption.getValue(); assertEquals(WriteOption.OptionType.LOG_DESTINATION, writeOption.getOptionType()); assertEquals(LogDestinationName.DestinationType.PROJECT, resource.getDestinationType()); - assertEquals(PROJECT_NAME, resource.getId()); + assertEquals(PROJECT_NAME, resource.getDestinationId()); writeOption = WriteOption.destination(LogDestinationName.billingAccount(BILLING_NAME)); resource = (LogDestinationName) writeOption.getValue(); assertEquals(WriteOption.OptionType.LOG_DESTINATION, writeOption.getOptionType()); assertEquals(LogDestinationName.DestinationType.BILLINGACCOUNT, resource.getDestinationType()); - assertEquals(BILLING_NAME, resource.getId()); + assertEquals(BILLING_NAME, resource.getDestinationId()); writeOption = WriteOption.destination(LogDestinationName.folder(FOLDER_NAME)); resource = (LogDestinationName) writeOption.getValue(); assertEquals(WriteOption.OptionType.LOG_DESTINATION, writeOption.getOptionType()); assertEquals(LogDestinationName.DestinationType.FOLDER, resource.getDestinationType()); - assertEquals(FOLDER_NAME, resource.getId()); + assertEquals(FOLDER_NAME, resource.getDestinationId()); writeOption = WriteOption.destination(LogDestinationName.organization(ORGANIZATION_NAME)); resource = (LogDestinationName) writeOption.getValue(); assertEquals(WriteOption.OptionType.LOG_DESTINATION, writeOption.getOptionType()); assertEquals(LogDestinationName.DestinationType.ORGANIZATION, resource.getDestinationType()); - assertEquals(ORGANIZATION_NAME, resource.getId()); + assertEquals(ORGANIZATION_NAME, resource.getDestinationId()); } }