Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

feat: replace the usage of KeyName and CryptoKeyPathName with the interface ResourceName #117

Merged
merged 3 commits into from Mar 26, 2020
Merged

feat: replace the usage of KeyName and CryptoKeyPathName with the interface ResourceName #117

merged 3 commits into from Mar 26, 2020

Conversation

yihanzhen
Copy link
Contributor

@yihanzhen yihanzhen commented Mar 26, 2020 •
edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

yoshi-automation and others added 2 commits March 25, 2020 15:17
@yoshi-automation
Turn on gapic config v2 for kms.
cc6b589 
googleapis/googleapis@0341fa3
commit 0341fa3fc2f4073a1b1f260d37b2ce620799f545
Author: Google APIs <noreply@google.com>
Date:   Wed Mar 25 15:11:36 2020 -0700

    Turn on gapic config v2 for kms.

    Committer: @hzyi-google
    PiperOrigin-RevId: 302980301

google/cloud/kms/v1/cloudkms_gapic.legacy.yaml
google/cloud/kms/v1/cloudkms_gapic.yaml
@yihanzhen
manual updates
5cdc70f
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 26, 2020
@codecov
Copy link

codecov bot commented Mar 26, 2020 •
edited

Codecov Report

Merging #117 into master will decrease coverage by 1.1%.
The diff coverage is 90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #117      +/-   ##
============================================
- Coverage     77.78%   76.67%   -1.11%     
+ Complexity      153      150       -3     
============================================
  Files             6        6              
  Lines          1337     1342       +5     
  Branches          5        5              
============================================
- Hits           1040     1029      -11     
- Misses          269      288      +19     
+ Partials         28       25       -3
Impacted Files Coverage Δ Complexity Δ
...oogle/cloud/kms/v1/KeyManagementServiceClient.java 59.93% <90%> (-4.42%) 77 <6> (-3)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a90038a...981043a. Read the comment docs.

@yihanzhen
Copy link
Contributor Author

@chingor13 PTAL

@chingor13 chingor13 merged commit 0c57b5f into googleapis:master Mar 26, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 1, 2020
@release-please
chore: release 1.37.0 (#119)
32a411b 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.37.0](https://www.github.com/googleapis/java-kms/compare/v1.36.1...v1.37.0) (2020-04-01)


### Features

* replace the usage of KeyName and CryptoKeyPathName with the interface ResourceName ([#117](https://www.github.com/googleapis/java-kms/issues/117)) ([0c57b5f](https://www.github.com/googleapis/java-kms/commit/0c57b5f246aeba9ca1b2733e288a6a04f4e14acc))


### Bug Fixes

* undeprecate resource name classes until multi-pattern resources are available ([#91](https://www.github.com/googleapis/java-kms/issues/91)) ([ebdefc2](https://www.github.com/googleapis/java-kms/commit/ebdefc2a883da7b6614e0d1fb602550454a77718))


### Dependencies

* update core libraries ([#90](https://www.github.com/googleapis/java-kms/issues/90)) ([a98636c](https://www.github.com/googleapis/java-kms/commit/a98636c3a842e2a30bd616729d0e59e4917c9909))
* update dependency com.google.api:api-common to v1.9.0 ([#114](https://www.github.com/googleapis/java-kms/issues/114)) ([163c590](https://www.github.com/googleapis/java-kms/commit/163c5907b824303de275e71c832712a93613ed99))
* update dependency com.google.cloud:google-cloud-core to v1.92.5 ([32fab45](https://www.github.com/googleapis/java-kms/commit/32fab455149c0084a4c85d86050ad697d0ef9cf8))
* update dependency com.google.cloud:google-cloud-core to v1.93.1 ([#92](https://www.github.com/googleapis/java-kms/issues/92)) ([2a49211](https://www.github.com/googleapis/java-kms/commit/2a49211f2504b5c5618fc3ecc2db6bbae35b0609))
* update dependency com.google.http-client:google-http-client-bom to v1.34.2 ([#80](https://www.github.com/googleapis/java-kms/issues/80)) ([3b61f2e](https://www.github.com/googleapis/java-kms/commit/3b61f2ea83bcccf45c0f9ecd9016bb8255d28b42))
* update dependency com.google.protobuf:protobuf-java to v3.11.4 ([#82](https://www.github.com/googleapis/java-kms/issues/82)) ([7c15f29](https://www.github.com/googleapis/java-kms/commit/7c15f2989c327e80e4cb4187d520691b068d6d86))
* update dependency io.grpc:grpc-bom to v1.27.1 ([#81](https://www.github.com/googleapis/java-kms/issues/81)) ([ced89b5](https://www.github.com/googleapis/java-kms/commit/ced89b5cfe783aa3d13d500ae55890217133b66d))


### Documentation

* **regen:** update sample code to set total timeout, add API client header test ([45a2396](https://www.github.com/googleapis/java-kms/commit/45a23964f51f42df0bc273045a5d095842d0522a))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
yoshi-automation added a commit that referenced this pull request Apr 1, 2020
@yoshi-automation
chore: release 1.37.0 (#119)
3929cbf 
32a411b
commit 32a411b
Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Date:   Wed Apr 1 21:22:08 2020 +0000

    chore: release 1.37.0 (#119)

    🤖 I have created a release \*beep\* \*boop\*
    ---
    ## [1.37.0](https://www.github.com/googleapis/java-kms/compare/v1.36.1...v1.37.0) (2020-04-01)

    ### Features

    * replace the usage of KeyName and CryptoKeyPathName with the interface ResourceName ([#117](https://www.github.com/googleapis/java-kms/issues/117)) ([0c57b5f](https://www.github.com/googleapis/java-kms/commit/0c57b5f246aeba9ca1b2733e288a6a04f4e14acc))

    ### Bug Fixes

    * undeprecate resource name classes until multi-pattern resources are available ([#91](https://www.github.com/googleapis/java-kms/issues/91)) ([ebdefc2](https://www.github.com/googleapis/java-kms/commit/ebdefc2a883da7b6614e0d1fb602550454a77718))

    ### Dependencies

    * update core libraries ([#90](https://www.github.com/googleapis/java-kms/issues/90)) ([a98636c](https://www.github.com/googleapis/java-kms/commit/a98636c3a842e2a30bd616729d0e59e4917c9909))
    * update dependency com.google.api:api-common to v1.9.0 ([#114](https://www.github.com/googleapis/java-kms/issues/114)) ([163c590](https://www.github.com/googleapis/java-kms/commit/163c5907b824303de275e71c832712a93613ed99))
    * update dependency com.google.cloud:google-cloud-core to v1.92.5 ([32fab45](https://www.github.com/googleapis/java-kms/commit/32fab455149c0084a4c85d86050ad697d0ef9cf8))
    * update dependency com.google.cloud:google-cloud-core to v1.93.1 ([#92](https://www.github.com/googleapis/java-kms/issues/92)) ([2a49211](https://www.github.com/googleapis/java-kms/commit/2a49211f2504b5c5618fc3ecc2db6bbae35b0609))
    * update dependency com.google.http-client:google-http-client-bom to v1.34.2 ([#80](https://www.github.com/googleapis/java-kms/issues/80)) ([3b61f2e](https://www.github.com/googleapis/java-kms/commit/3b61f2ea83bcccf45c0f9ecd9016bb8255d28b42))
    * update dependency com.google.protobuf:protobuf-java to v3.11.4 ([#82](https://www.github.com/googleapis/java-kms/issues/82)) ([7c15f29](https://www.github.com/googleapis/java-kms/commit/7c15f2989c327e80e4cb4187d520691b068d6d86))
    * update dependency io.grpc:grpc-bom to v1.27.1 ([#81](https://www.github.com/googleapis/java-kms/issues/81)) ([ced89b5](https://www.github.com/googleapis/java-kms/commit/ced89b5cfe783aa3d13d500ae55890217133b66d))

    ### Documentation

    * **regen:** update sample code to set total timeout, add API client header test ([45a2396](https://www.github.com/googleapis/java-kms/commit/45a23964f51f42df0bc273045a5d095842d0522a))
    ---

    This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
4 participants
@yihanzhen @chingor13 @googlebot @yoshi-automation