fix: check whether or not we created destination directory #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
stephaniewang526
approved these changes
Sep 17, 2020
chingor13
added
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 25, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [0.1.1](https://www.github.com/googleapis/java-gcloud-maven-plugin/compare/v0.1.0...v0.1.1) (2021-02-25) ### Bug Fixes * check whether or not we created destination directory ([#81](https://www.github.com/googleapis/java-gcloud-maven-plugin/issues/81)) ([4bf31df](https://www.github.com/googleapis/java-gcloud-maven-plugin/commit/4bf31df4fa1f99f8223d745ea396d3e0ed2bf886)), closes [#47](https://www.github.com/googleapis/java-gcloud-maven-plugin/issues/47) ### Dependencies * update dependency com.google.cloud.samples:shared-configuration to v1.0.13 ([#49](https://www.github.com/googleapis/java-gcloud-maven-plugin/issues/49)) ([d49b1c5](https://www.github.com/googleapis/java-gcloud-maven-plugin/commit/d49b1c5237e86627f2d13cb317ef9a4a393e89cc)) * update dependency commons-io:commons-io to v2.8.0 ([#63](https://www.github.com/googleapis/java-gcloud-maven-plugin/issues/63)) ([f63f4bb](https://www.github.com/googleapis/java-gcloud-maven-plugin/commit/f63f4bb0013f7874dd6ca348f1a47e922075e162)) * update dependency org.apache.commons:commons-compress to v1.20 ([#40](https://www.github.com/googleapis/java-gcloud-maven-plugin/issues/40)) ([ff9ef3e](https://www.github.com/googleapis/java-gcloud-maven-plugin/commit/ff9ef3e84c732318aac1e8e65d3658b9a5bb2663)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File#mkdirs()will already throw security errors if it fails. We don't want to fail here asFile.#mkdirs()will returnfalseif the directory already exists - thus we should only log this case if the later file write fails.Fixes #47