Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We don't check return value of mkdirs #47

Closed
elharo opened this issue Mar 18, 2020 · 0 comments · Fixed by #81
Closed

We don't check return value of mkdirs #47

elharo opened this issue Mar 18, 2020 · 0 comments · Fixed by #81
Assignees
Labels
good first issue This issue is a good place to started contributing to this repository. help wanted We'd love to have community involvement on this issue. priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@elharo
Copy link
Contributor

elharo commented Mar 18, 2020

In DownloadComponentsMojo

@elharo elharo added help wanted We'd love to have community involvement on this issue. good first issue This issue is a good place to started contributing to this repository. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 18, 2020
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Mar 19, 2020
@chingor13 chingor13 added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Mar 24, 2020
@yoshi-automation yoshi-automation removed triage me I really want to be triaged. 🚨 This issue needs some love. labels Mar 24, 2020
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jun 22, 2020
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Sep 14, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 17, 2020
`File#mkdirs()` will already throw security errors if it fails.  We don't want to fail here as `File.#mkdirs()` will return `false` if the directory already exists - thus we should only log this case if the later file write fails.

Fixes #47
gcf-merge-on-green bot pushed a commit that referenced this issue Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This issue is a good place to started contributing to this repository. help wanted We'd love to have community involvement on this issue. priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants