From 4cf51852779c55b4dd9f5e636b4227c0ab053ae1 Mon Sep 17 00:00:00 2001 From: Elliotte Rusty Harold Date: Tue, 16 Mar 2021 16:09:58 +0000 Subject: [PATCH] fix: remove commons io dependency (#113) * remove commons-io dependency * remove guava * remove commons-io dependency * format --- pom.xml | 7 ----- .../google/cloud/DownloadComponentsMojo.java | 26 ++++++++++++------- 2 files changed, 16 insertions(+), 17 deletions(-) diff --git a/pom.xml b/pom.xml index 0717c01..14d33c3 100644 --- a/pom.xml +++ b/pom.xml @@ -95,12 +95,5 @@ commons-compress 1.20 - - - - commons-io - commons-io - 2.6 - diff --git a/src/main/java/com/google/cloud/DownloadComponentsMojo.java b/src/main/java/com/google/cloud/DownloadComponentsMojo.java index 05fcc66..45d9817 100644 --- a/src/main/java/com/google/cloud/DownloadComponentsMojo.java +++ b/src/main/java/com/google/cloud/DownloadComponentsMojo.java @@ -53,7 +53,6 @@ import org.apache.commons.compress.compressors.gzip.GzipCompressorInputStream; import org.apache.commons.compress.utils.IOUtils; import org.apache.commons.compress.utils.Lists; -import org.apache.commons.io.FileUtils; import org.apache.maven.execution.MavenSession; import org.apache.maven.plugin.AbstractMojo; import org.apache.maven.plugin.MojoExecutionException; @@ -242,15 +241,14 @@ private void updateCachedManifest() throws IOException { @SuppressWarnings("unused") boolean ignored = localCache.delete(); - FileUtils.moveFile(tempFile, localCache); + Files.move(tempFile.toPath(), localCache.toPath()); } /** Parse the locally cached manifest and extract the relevant components. */ private List parseManifest() throws IOException { - JsonParser parser = new JsonParser(); JsonElement json; try (FileReader reader = new FileReader(getManifestCache())) { - json = parser.parse(reader); + json = JsonParser.parseReader(reader); } JsonArray jsonComponents = json.getAsJsonObject().get("components").getAsJsonArray(); @@ -274,10 +272,9 @@ private Map parseLocalChecksums() throws IOException { JsonElement json = new JsonObject(); if (getChecksumFile().exists()) { - JsonParser parser = new JsonParser(); try (FileReader reader = new FileReader(getChecksumFile())) { - json = parser.parse(reader); + json = JsonParser.parseReader(reader); } } @@ -366,8 +363,18 @@ private void downloadComponent(Component component) throws IOException, NoSuchAl // Move it into place File localPath = getComponentPath(component); - FileUtils.deleteDirectory(localPath); - FileUtils.moveDirectory(tmpPath, localPath); + deleteRecursively(localPath); + Files.move(tmpPath.toPath(), localPath.toPath()); + } + + private static void deleteRecursively(File directory) { + File[] contents = directory.listFiles(); + if (contents != null) { + for (File file : contents) { + deleteRecursively(file); + } + } + directory.delete(); } private static String byteArrayToHex(byte[] a) { @@ -386,9 +393,8 @@ private void writeLocalChecksums(List components) throws IOException JsonObject results = new JsonObject(); try { - JsonParser parser = new JsonParser(); try (FileReader reader = new FileReader(getChecksumFile())) { - results = parser.parse(reader).getAsJsonObject(); + results = JsonParser.parseReader(reader).getAsJsonObject(); } } catch (FileNotFoundException e) { // ignored