Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove error_prone_annotations exclusion rules from poms #97

Merged
merged 1 commit into from Feb 7, 2020

Conversation

athakor
Copy link
Contributor

@athakor athakor commented Feb 6, 2020

Fixes #96

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 6, 2020
@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #97 into master will decrease coverage by 0.41%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #97      +/-   ##
============================================
- Coverage     71.33%   70.91%   -0.42%     
+ Complexity      988      957      -31     
============================================
  Files            62       62              
  Lines          5323     5199     -124     
  Branches        599      579      -20     
============================================
- Hits           3797     3687     -110     
+ Misses         1339     1333       -6     
+ Partials        187      179       -8
Impacted Files Coverage Δ Complexity Δ
...cloud/firestore/collection/ImmutableSortedMap.java 13.95% <0%> (-1.96%) 1% <0%> (ø)
...oogle/cloud/firestore/v1beta1/FirestoreClient.java 54.63% <0%> (-1.56%) 25% <0%> (-6%)
...com/google/cloud/firestore/v1/FirestoreClient.java 54.63% <0%> (-1.56%) 25% <0%> (-6%)
.../java/com/google/cloud/firestore/Precondition.java 68.18% <0%> (-1.39%) 12% <0%> (-3%)
...gle/cloud/firestore/v1/stub/GrpcFirestoreStub.java 93.67% <0%> (-0.57%) 16% <0%> (-1%)
...loud/firestore/v1beta1/stub/GrpcFirestoreStub.java 93.67% <0%> (-0.57%) 16% <0%> (-1%)
...a/com/google/cloud/firestore/FirestoreOptions.java 36.44% <0%> (-0.54%) 7% <0%> (ø)
...loud/firestore/v1/stub/GrpcFirestoreAdminStub.java 94.32% <0%> (-0.46%) 15% <0%> (-1%)
...ain/java/com/google/cloud/firestore/FieldMask.java 87.09% <0%> (-0.41%) 13% <0%> (-2%)
...cloud/firestore/v1/stub/FirestoreStubSettings.java 79.26% <0%> (-0.38%) 22% <0%> (-1%)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ef398c...9f20ef5. Read the comment docs.

@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2020
@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2020
@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Temporary error_prone_annotations exclusion rules from poms
4 participants