Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(java): syncing java and android snippets #877

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(java): syncing java and android snippets #877

wants to merge 4 commits into from

Conversation

paulsmithkc
Copy link

Fixes #876 ☕️

@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/java-firestore API. label Feb 16, 2022
@snippet-bot
Copy link

snippet-bot bot commented Feb 16, 2022 •
edited

Here is the summary of possible violations 😱

There is a possible violation for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.

Here is the summary of changes.

You are about to add 2 region tags.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@paulsmithkc
Copy link
Author

Snippet tags were moved to cover the entire class. See #876 and firebase/snippets-android#322

@paulsmithkc paulsmithkc mentioned this pull request Feb 16, 2022
Open
@ehsannas ehsannas added the snippet-bot:no-prefix-req Instruct snippet-bot to ignore prefix requirement label Feb 22, 2022
@ehsannas ehsannas changed the title syncing java and android snippets fix(java): syncing java and android snippets Feb 22, 2022
@meredithslota meredithslota removed the snippet-bot:no-prefix-req Instruct snippet-bot to ignore prefix requirement label Nov 10, 2022
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 10, 2022
@meredithslota
Copy link
Contributor

We will need to re-remove the obsolete region tag fs_class_definition after this is merged, but it is easy to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/java-firestore API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Code snippet for City class does not match Android Java version
4 participants
@paulsmithkc @meredithslota @schmidt-sebastian @ehsannas