fix: set timeouts for BatchGetDocuments/RunQuery

[schmidt-sebastian]

We currently only apply the retry settings to Unary methods, which means that the user cannot specify a custom timeout for BatchGetDocuments and RunQuery requests.

[kolea2]

might be nice to add some asserts to the retry settings once built in a unit test?

[schmidt-sebastian]

Unfortunately, the code in the stub handler is not exercised by unit tests.

[kolea2]

right, can we add one? Something along the lines of:

 FirestoreOptions firestoreOptions =
                FirestoreOptions.newBuilder()
                        .setRetrySettings(
                                RetrySettings.newBuilder()
                                        .setMaxRpcTimeout(Duration.ofMillis(1))
                                        .setTotalTimeout(Duration.ofMillis(1))
                                        .setInitialRpcTimeout(Duration.ofMillis(1))
                                        .build())
                        .build();

Duration maxRpcTimeout = firestoreOptions.getRetrySettings().getMaxRpcTimeout();
Truth.assertThat(maxRpcTimeout).isEqualTo(Duration.ofMillis(1));

[kolea2]

and could add additional cases for the unary timeouts that were already getting set.

[schmidt-sebastian]

IMHO, this would not catch the issue here. The issue is that the retry settings do not get applied correctly to the underlying RCPs, not that the settings itself are off. The code snippet you provided is just auto-generated code (unless I misunderstood the intent)

[kolea2]

Got it - I thought FirestoreOptions was handwritten. SGTM