Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add google-cloud-firestore to bom #65

Merged
merged 1 commit into from Jan 2, 2020
Merged

fix: add google-cloud-firestore to bom #65

merged 1 commit into from Jan 2, 2020

Conversation

BenWhitehead
Copy link
Collaborator

Fixes #64

@BenWhitehead BenWhitehead requested a review from a team January 2, 2020 20:41
@BenWhitehead BenWhitehead self-assigned this Jan 2, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 2, 2020
@codecov
Copy link

codecov bot commented Jan 2, 2020 •
edited

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #65   +/-   ##
=========================================
  Coverage     71.33%   71.33%           
- Complexity      988      997    +9     
=========================================
  Files            62       62           
  Lines          5323     5323           
  Branches        599      597    -2     
=========================================
  Hits           3797     3797           
  Misses         1339     1339           
  Partials        187      187

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f80e44...ccdc4b0. Read the comment docs.

@kurtisvg kurtisvg mentioned this pull request Jan 2, 2020
Merged
1 task
@BenWhitehead BenWhitehead merged commit b273a58 into googleapis:master Jan 2, 2020
@BenWhitehead BenWhitehead deleted the bom-fix branch January 2, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees

@BenWhitehead BenWhitehead

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google-cloud-firestore is missing from libraries bom 3.1.0 - 3.3.0
4 participants
@BenWhitehead @chingor13 @kurtisvg @googlebot