Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't throw NPE in DocumentSnapshot.getDate() when value is missing #513

Merged
merged 2 commits into from Jan 26, 2021
Merged

fix: don't throw NPE in DocumentSnapshot.getDate() when value is missing #513

merged 2 commits into from Jan 26, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

Fixes #491

@schmidt-sebastian schmidt-sebastian requested a review from a team as a code owner January 26, 2021 21:50
@schmidt-sebastian schmidt-sebastian requested a review from a team January 26, 2021 21:50
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 26, 2021
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/java-firestore API. label Jan 26, 2021
@codecov
Copy link

codecov bot commented Jan 26, 2021 •
edited

Codecov Report

Merging #513 (a650223) into master (0e6f3da) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #513      +/-   ##
============================================
- Coverage     74.09%   74.08%   -0.02%     
+ Complexity     1117     1108       -9     
============================================
  Files            66       66              
  Lines          5883     5884       +1     
  Branches        723      726       +3     
============================================
  Hits           4359     4359              
  Misses         1296     1296              
- Partials        228      229       +1
Impacted Files Coverage Δ Complexity Δ
...a/com/google/cloud/firestore/DocumentSnapshot.java 80.85% <50.00%> (-0.87%) 39.00 <1.00> (ø)
.../com/google/cloud/firestore/BulkWriterOptions.java 100.00% <0.00%> (ø) 2.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e6f3da...a650223. Read the comment docs.

thebrianchen
thebrianchen approved these changes Jan 26, 2021
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@schmidt-sebastian schmidt-sebastian merged commit a41b07e into master Jan 26, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/fixtodate branch January 26, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebrianchen thebrianchen thebrianchen approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore Issues related to the googleapis/java-firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Null field value is treated inconsistently in DocumentSnapshot get{Type} methods (return null vs throw NPE)
2 participants
@schmidt-sebastian @thebrianchen