fix(samples): close firestore instance in test #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: firestore
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
samples
Codecov Report
@@ Coverage Diff @@
## master #476 +/- ##
=========================================
Coverage 73.40% 73.40%
Complexity 1086 1086
=========================================
Files 65 65
Lines 5786 5786
Branches 723 723
=========================================
Hits 4247 4247
Misses 1313 1313
Partials 226 226 Continue to review full report at Codecov.
|
suraj-qlogic
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
@BenWhitehead ,PTAL |
| @@ -644,4 +644,9 @@ Query filterNotIn() { | |||
| // [END fs_filter_not_in] | |||
| return query; | |||
| } | |||
|
|
|||
| /** Closes the gRPC channels associated with this instance and frees up their resources. */ | |||
| void close() throws Exception { | |||
There was a problem hiding this comment.
Does this need to be overridden? It seems like the method in BaseIntegrationTest does the right thing already.
There was a problem hiding this comment.
Yes,because QueryDataSnippets class also have instance variable with name db of type Firestore means BaseIntegrationTest have different instance while QueryDataSnippets class have a different instance of Firestore.
schmidt-sebastian
approved these changes
Dec 4, 2020
BenWhitehead
approved these changes
Dec 9, 2020
elharo
approved these changes
Jan 21, 2021
chingor13
approved these changes
Feb 10, 2021
lesv
approved these changes
Feb 11, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 19, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [2.2.2](https://www.github.com/googleapis/java-firestore/compare/v2.2.1...v2.2.2) (2021-02-19) ### Bug Fixes * block close() on the termination of all RPC channels ([#512](https://www.github.com/googleapis/java-firestore/issues/512)) ([67bd06a](https://www.github.com/googleapis/java-firestore/commit/67bd06aac7a53a210e1a5c081929104c43a5d48a)) * **samples:** close firestore instance in test ([#476](https://www.github.com/googleapis/java-firestore/issues/476)) ([fb1cb17](https://www.github.com/googleapis/java-firestore/commit/fb1cb175c06e2782f7cd9cb3bbb9c751e9d33713)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #474