Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GAPIC Generator to v2 #38

Closed
BenWhitehead opened this issue Dec 5, 2019 · 1 comment
Closed

Update GAPIC Generator to v2 #38

BenWhitehead opened this issue Dec 5, 2019 · 1 comment
Assignees
@BenWhitehead
Labels
api: firestore Issues related to the googleapis/java-firestore API. semver: major Hint for users that this is an API breaking change. type: process A process-related concern. May include testing, release, or the like.

Comments

@BenWhitehead
Copy link
Collaborator

When the update takes place, there will be a breaking change in the protos generated for firestore-admin due to the new resource definition added in https://github.com/googleapis/java-firestore/pull/37/files#diff-146d4fb0c9d1f24906947fa0feca08f3R41-R44 this change will necessitate a major version bump at the very least for the proto-google-cloud-firestore-admin-v1.
@BenWhitehead BenWhitehead added type: process A process-related concern. May include testing, release, or the like. semver: major Hint for users that this is an API breaking change. labels Dec 5, 2019
@BenWhitehead BenWhitehead mentioned this issue Dec 5, 2019
Merged
@google-cloud-label-sync google-cloud-label-sync bot added the api: firestore Issues related to the googleapis/java-firestore API. label Jan 29, 2020
@BenWhitehead
Copy link
Collaborator Author

Completed in #188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenWhitehead BenWhitehead

Labels
api: firestore Issues related to the googleapis/java-firestore API. semver: major Hint for users that this is an API breaking change. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BenWhitehead