Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary animal-sniffer-annotations exclusion rules in poms. #33

Closed
BenWhitehead opened this issue Dec 4, 2019 · 1 comment · Fixed by #76
Closed

Temporary animal-sniffer-annotations exclusion rules in poms. #33

BenWhitehead opened this issue Dec 4, 2019 · 1 comment · Fixed by #76
Assignees
Labels
api: firestore Issues related to the googleapis/java-firestore API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@BenWhitehead
Copy link
Collaborator

As of grpc-api:1.25.0 and guava:28.1-android there is a failure for animal-sniffer-annotations

[WARNING] Rule 2: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for org.codehaus.mojo:animal-sniffer-annotations:1.17 paths to dependency are:
+-com.google.api.grpc:grpc-google-cloud-firestore-admin-v1:1.32.0
  +-io.grpc:grpc-api:1.25.0
    +-org.codehaus.mojo:animal-sniffer-annotations:1.17
and
+-com.google.api.grpc:grpc-google-cloud-firestore-admin-v1:1.32.0
  +-com.google.guava:guava:28.1-android
    +-org.codehaus.mojo:animal-sniffer-annotations:1.18
]

There is no actual difference between the single annotation present in the versions, so it is being excluded for the time being.

The exclusion should be removed from the poms when there is no longer a disparity.

@BenWhitehead BenWhitehead added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 4, 2019
BenWhitehead added a commit that referenced this issue Dec 4, 2019
@elharo
Copy link
Contributor

elharo commented Jan 3, 2020

FYI, Guava 28.2 no longer depends on animal-sniffer-annotations. It should also be possible to remove that dependency from other artifacts where it appears.

BenWhitehead added a commit that referenced this issue Jan 9, 2020
)

* deps: update dependency com.google.guava:guava-bom to v28.2-android

* build: add exclusion of error_prone_annotations to grpc-api usage

Fixes #33

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
@google-cloud-label-sync google-cloud-label-sync bot added the api: firestore Issues related to the googleapis/java-firestore API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/java-firestore API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants