feat: add BulkWriter #323
Merged
feat: add BulkWriter #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: add retry on ABORTED errors * WIP: test pass individually, concurrency error * WIP: tests passing but hidden concurrency bug * use BulkCommitBatch constructor, remove completeFuture * use firestoreExecutor and update rate limiter test * add todo for successfulAsList * Update BulkWriterTest to check number of retry attempts * build: manually bump com.google.api:api-common to v1.10.0 This change should be cleaned up after com.google.com:google-cloud-shared-dependencies v0.8.4 is available * test: add junit timeout rule to BulkWriterTest (#312) * update to use successfulAsList * add test to verify successfulAsList * lint * resolve comments, fix concurrency issue? * resolve comments, add additional test for flush Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #323 +/- ##
============================================
+ Coverage 72.08% 72.62% +0.53%
- Complexity 979 1039 +60
============================================
Files 60 64 +4
Lines 5145 5475 +330
Branches 649 677 +28
============================================
+ Hits 3709 3976 +267
- Misses 1231 1288 +57
- Partials 205 211 +6 Continue to review full report at Codecov.
|
BenWhitehead
requested changes
Aug 10, 2020
google-cloud-firestore/src/main/java/com/google/cloud/firestore/BatchWriteResult.java
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/BulkWriter.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/BulkWriter.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/BulkWriter.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/BulkWriter.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/BulkWriterOptions.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/Transaction.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/UpdateBuilder.java
Show resolved
Hide resolved
BenWhitehead
approved these changes
Aug 11, 2020
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 14, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [2.0.0](https://www.github.com/googleapis/java-firestore/compare/v1.35.2...v2.0.0) (2020-08-14) ### New Features #### Query Partition API New API and backend RPC which allows for fetching a set of cursor keys for a Collection Group Query. Accessible via the new [`CollectionGroup#getPartitions(long,ApiStreamObserver)`](https://googleapis.dev/java/google-cloud-firestore/2.0.0/com/google/cloud/firestore/CollectionGroup.html#getPartitions-long-com.google.api.gax.rpc.ApiStreamObserver-) method. #### Read-Only Transaction Options [`TransactionOptions`](https://googleapis.dev/java/google-cloud-firestore/2.0.0/com/google/cloud/firestore/TransactionOptions.html) has been refactored to provide the ability to configure options for read-only transactions along with the existing configuration for read-write transactions. This new ability is provided via the new [`TransactionOptions.createReadOnlyOptionsBuilder()`](https://googleapis.dev/java/google-cloud-firestore/2.0.0/com/google/cloud/firestore/TransactionOptions.html#createReadOnlyOptionsBuilder--) type safe builder. Along with the new type safe builder for read-only options, there is a new type safe builder for read-write options as well accessible via [`TransactionOptions.createReadWriteOptionsBuilder()`](https://googleapis.dev/java/google-cloud-firestore/2.0.0/com/google/cloud/firestore/TransactionOptions.html#createReadWriteOptionsBuilder--). Each of the existing `TransactionOptions.create(...)` methods for configuring read-write options has been deprecated in favor of the new builder. #### EmulatorCredentials `com.google.cloud.firestore.FirestoreOptions.Builder.FakeCredentials` has been made static and renamed to `com.google.cloud.firestore.FirestoreOptions.EmulatorCredentials` allowing instantiation outside `FirestoreOptions.Builder`. When connecting to the Cloud Firestore Emulator via `FirestoreOptions` rather than the environment variable `FIRESTORE_EMULATOR_HOST`, a custom credential implementation must be specified to allow various admin operations in the emulator. Previously this required users to create their own implementation due to it not being possible to construct a `FakeCredential`. As part of this change, `EmulatorCredentials` is static and therefore able to be constructed from any location. ### Breaking Changes #### New Firestore Admin Client API Artifact The Cloud Firestore Admin Client has been migrated to its own maven artifact `com.google.cloud:google-cloud-firestore-admin` rather than being bundled in `com.google.cloud:google-cloud-firestore`. All packages and classes have retained their existing names. The new artifact is included in the `com.google.cloud:google-cloud-firestore-bom`, `com.google.cloud:google-cloud-bom` and `com.google.cloud:libraries-bom` artifacts and is accessible by adding the new dependency to your `pom.xml` file: ```xml <dependency> <groupId>com.google.cloud</groupId> <artifactId>google-cloud-firestore-admin</artifactId> </dependency> ``` #### Removal of v1beta1 Cloud Firestore has been GA for some time now, and the `google-cloud-firestore` code base has been using the protos and generated classes for the v1 api since that time. As such, we will no longer be publishing artifacts for the deprecated v1beta1 protos. All functionality from v1beta1 is present in v1, and all users should update any code to use v1. #### Removal of support for `java.util.Date` in Snapshots It is no longer possible to configure the ability for `java.util.Date` to be returned from `DocumentSnapshot.get(FieldPath)` or `DocumentSnapshot.getData()` for properties which are stored as Timestamps in Cloud Firestore. The default behavior has been to return `com.google.cloud.Timestamp` by default for some time, and is now the only option. Any code that is dependent on the old behavior must be updated to use Timestamps instead of Date. ### Laundry List of Pull Requests #### ⚠ BREAKING CHANGES * add support for the Query Partition API (#202) * `Firestore#collectionGroup(...)` has a new return type `CollectionGroup` which requires any code that previously used the method be re-compiled to pick up the new signature. `CollectionGroup` extends `Query` and as such does not require your code to be updated, only the compiled class files. * move FirestoreAdminClient and associated classes to new artifact google-cloud-firestore-admin (#311) * remove deprecated v1beta1 protos and grpc client (#305) * remove deprecated FirestoreOptions#setTimestampsInSnapshotsEnabled (#308) * remove deprecated getCollections() methods (#307) * various renames due to generator changes #### Features * add support for read-only transactions in TransactionOptions ([#320](https://www.github.com/googleapis/java-firestore/issues/320)) ([c25dca3](https://www.github.com/googleapis/java-firestore/commit/c25dca3ed6ca0c156ec60569ebc9f3a481bd4fee)) * add support for the Query Partition API ([#202](https://www.github.com/googleapis/java-firestore/issues/202)) ([3996548](https://www.github.com/googleapis/java-firestore/commit/39965489cbc836af573e500d57007c88241d7eb6)) #### Bug Fixes * refactor FakeCredentials ([#325](https://www.github.com/googleapis/java-firestore/issues/325)) ([269e62c](https://www.github.com/googleapis/java-firestore/commit/269e62c6b8031d48e7f2e282b09b5ffcfadae547)), closes [#190](https://www.github.com/googleapis/java-firestore/issues/190) #### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.5 ([#322](https://www.github.com/googleapis/java-firestore/issues/322)) ([1b21350](https://www.github.com/googleapis/java-firestore/commit/1b21350c0bc4a21cee2b281f944cbd061b1f8898)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.6 ([#324](https://www.github.com/googleapis/java-firestore/issues/324)) ([b945fdb](https://www.github.com/googleapis/java-firestore/commit/b945fdb04da76a1e007d012c809449c5a43bb990)) * update jackson dependencies to v2.11.2 ([#314](https://www.github.com/googleapis/java-firestore/issues/314)) ([15d68cd](https://www.github.com/googleapis/java-firestore/commit/15d68cd93ac1fd206895fd37155a9ba82b9196ca)) #### Miscellaneous Chores * enable gapicv2 ([#188](https://www.github.com/googleapis/java-firestore/issues/188)) ([92224bc](https://www.github.com/googleapis/java-firestore/commit/92224bcd52aa88cc6eb1da28747de0535d776a0f)) * move FirestoreAdminClient and associated classes to new artifact google-cloud-firestore-admin ([#311](https://www.github.com/googleapis/java-firestore/issues/311)) ([03ef755](https://www.github.com/googleapis/java-firestore/commit/03ef755dd164e6f1ec749f3f985b913b5ae23d14)) * remove deprecated FirestoreOptions#setTimestampsInSnapshotsEnabled ([#308](https://www.github.com/googleapis/java-firestore/issues/308)) ([7255a42](https://www.github.com/googleapis/java-firestore/commit/7255a42bcee3a6938dd5fafaef3465f948f39600)) * remove deprecated getCollections() methods ([#307](https://www.github.com/googleapis/java-firestore/issues/307)) ([bb4ddf1](https://www.github.com/googleapis/java-firestore/commit/bb4ddf1ce3cc3bd2e06a4ad5097bd18060e4467b)) * remove deprecated v1beta1 protos and grpc client ([#305](https://www.github.com/googleapis/java-firestore/issues/305)) ([96adacb](https://www.github.com/googleapis/java-firestore/commit/96adacbf52ace27e54b7a210d7c73b46922fbcbd)) * add BulkWriter ([#323](https://www.github.com/googleapis/java-firestore/issues/323)) ([e7054df](https://www.github.com/googleapis/java-firestore/commit/e7054df79b4139fdfd0cc6aa0620fbfa1a10a6b0)) * make BulkWriter package private ([#330](#330)) ([ef0869a](ef0869a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.