Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose FirestoreImpl.autoId() for use in frameworks #292

Merged
merged 1 commit into from Jul 13, 2020

Conversation

dmitry-s
Copy link
Contributor

@dmitry-s dmitry-s commented Jul 10, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #291 ☕️

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2020
@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #292 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #292      +/-   ##
============================================
- Coverage     72.99%   72.98%   -0.02%     
+ Complexity     1055     1044      -11     
============================================
  Files            64       64              
  Lines          5525     5526       +1     
  Branches        643      645       +2     
============================================
  Hits           4033     4033              
- Misses         1281     1282       +1     
  Partials        211      211              
Impacted Files Coverage Δ Complexity Δ
...main/java/com/google/cloud/firestore/Internal.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ddb8f1...e56cf8a. Read the comment docs.

@schmidt-sebastian schmidt-sebastian changed the title expose FirestoreImpl.autoId() for use in frameworks fix: expose FirestoreImpl.autoId() for use in frameworks Jul 10, 2020
@BenWhitehead BenWhitehead merged commit b91c57c into googleapis:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose auto id generation
4 participants