feat: add support for fieldmask to document reference #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
suraj-qlogic
changed the title
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
============================================
+ Coverage 72.92% 73.01% +0.08%
- Complexity 1024 1025 +1
============================================
Files 64 64
Lines 5430 5444 +14
Branches 614 620 +6
============================================
+ Hits 3960 3975 +15
- Misses 1270 1271 +1
+ Partials 200 198 -2
Continue to review full report at Codecov.
|
suraj-qlogic
changed the title
BenWhitehead
requested changes
Jun 12, 2020
There was a problem hiding this comment.
Thanks for adding this @suraj-qlogic. One small request for the integration test.
| DocumentReference ref = randomColl.document("doc1"); | ||
| ref.set(ALL_SUPPORTED_TYPES_MAP).get(); | ||
| DocumentSnapshot documentSnapshots = ref.get(FieldMask.of("foo")).get(); | ||
| assertEquals("bar", documentSnapshots.get("foo")); |
There was a problem hiding this comment.
Can you add an assertion for the absence of one of the fields that should not be returned?
BenWhitehead
approved these changes
Jun 15, 2020
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 17, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.35.0](https://www.github.com/googleapis/java-firestore/compare/v1.34.0...v1.35.0) (2020-06-17) ### Features * ability to serialize Query to Proto ([#241](https://www.github.com/googleapis/java-firestore/issues/241)) ([bae22e0](https://www.github.com/googleapis/java-firestore/commit/bae22e0839de55e11dda604c3034feaedbbc172a)) * add support for fieldmask to document reference ([#245](https://www.github.com/googleapis/java-firestore/issues/245)) ([4a846b1](https://www.github.com/googleapis/java-firestore/commit/4a846b1f067ad8e462df673ada38589da224fcef)) ### Dependencies * update core dependencies ([#254](https://www.github.com/googleapis/java-firestore/issues/254)) ([9b275ca](https://www.github.com/googleapis/java-firestore/commit/9b275ca5b3f2adbe18be77ea8c86d8446a5833d6)) * update dependency com.google.api:api-common to v1.9.2 ([#238](https://www.github.com/googleapis/java-firestore/issues/238)) ([c47d327](https://www.github.com/googleapis/java-firestore/commit/c47d32705645a76d8f9598aa954dbc3b1c067c73)) * update dependency io.grpc:grpc-bom to v1.30.0 ([#244](https://www.github.com/googleapis/java-firestore/issues/244)) ([b5749d4](https://www.github.com/googleapis/java-firestore/commit/b5749d4e9bac3628da66451fa070c1bf6f852614)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227