Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: Add example snippets for stale reads #1273

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

samples: Add example snippets for stale reads #1273

wants to merge 3 commits into from

Conversation

jlara310
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [x ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [ x] Ensure the tests and linter pass
  • [ x] Code coverage does not decrease (if any source code was changed)
  • [ x] Appropriate docs were updated (if necessary)

Fixes #1271 ☕️

If you write sample code, please follow the samples format.

@snippet-bot
Copy link

snippet-bot bot commented Apr 26, 2023 •
edited

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: firestore Issues related to the googleapis/java-firestore API. samples Issues that are directly related to samples. labels Apr 26, 2023
@jlara310 jlara310 mentioned this pull request Apr 26, 2023
Open
@jlara310
Copy link
Contributor Author

@MarkDuckworth PTAL

MarkDuckworth
MarkDuckworth approved these changes Apr 26, 2023
View reviewed changes
Copy link

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

samples/snippets/src/main/java/com/example/firestore/snippets/QueryDataSnippets.java Show resolved Hide resolved
samples/snippets/src/test/java/com/example/firestore/snippets/QueryDataSnippetsIT.java Show resolved Hide resolved
@anguillanneuf anguillanneuf added the owlbot:run Add this label to trigger the Owlbot post processor. label May 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 8, 2023
anguillanneuf
anguillanneuf approved these changes May 8, 2023
View reviewed changes
Copy link

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlara310 please work with a tech writer to add the samples to docs next!

@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners May 8, 2023 17:42
@anguillanneuf anguillanneuf added the owlbot:ignore instruct owl-bot to ignore a PR label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

@anguillanneuf anguillanneuf anguillanneuf approved these changes

Assignees

@anguillanneuf anguillanneuf

Labels
api: firestore Issues related to the googleapis/java-firestore API. owlbot:ignore instruct owl-bot to ignore a PR samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a snippet demonstrating a stale read.
4 participants
@jlara310 @MarkDuckworth @anguillanneuf @alicejli