Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add snippet and test for a Firestore client with a regional endpoint #1256

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs: add snippet and test for a Firestore client with a regional endpoint #1256

wants to merge 2 commits into from

Conversation

jlara310
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [ x] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [ x] Ensure the tests and linter pass
  • [ x] Code coverage does not decrease (if any source code was changed)
  • [ x] Appropriate docs were updated (if necessary)

Fixes #1255 ☕️

If you write sample code, please follow the samples format.

@jlara310 jlara310 requested review from a team as code owners April 11, 2023 03:29
@snippet-bot
Copy link

snippet-bot bot commented Apr 11, 2023 •
edited

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Apr 11, 2023 •
edited

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@generated-files-bot
Copy link

generated-files-bot bot commented Apr 11, 2023 •
edited

Warning: This pull request is touching the following templated files:

  • samples/install-without-bom/pom.xml
  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: firestore Issues related to the googleapis/java-firestore API. labels Apr 11, 2023
@jlara310
Copy link
Contributor Author

@kolea2 , PTAL

@jlara310 jlara310 force-pushed the firestore-endpoint branch 2 times, most recently from af89f65 to fdf565d Compare April 11, 2023 15:34
@jlara310
Copy link
Contributor Author

@telpirion , could you review this one, too?

@jlara310
Copy link
Contributor Author

jlara310 commented May 8, 2023

@MarkDuckworth , could you help review this code snippet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/java-firestore API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create snippet that shows how to configure a regional endpoint
1 participant
@jlara310