From d3458cbdae14e1f623dcb9848dd0fc51b8a8c30f Mon Sep 17 00:00:00 2001 From: BenWhitehead Date: Fri, 20 Mar 2020 15:39:44 -0400 Subject: [PATCH] fix: add missing @InternalExtensionOnly annotation to com.google.cloud.firestore.Firestore (#141) "Client" interfaces make guarantees around compatibility for users direct usage, however no guarantee is made for anyone implementing the "client" interface themselves. This change adds the annotation intended to convey this guarantee at the code level and in javadocs that should have been here all along. --- .../src/main/java/com/google/cloud/firestore/Firestore.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/google-cloud-firestore/src/main/java/com/google/cloud/firestore/Firestore.java b/google-cloud-firestore/src/main/java/com/google/cloud/firestore/Firestore.java index 8c0301b3d..929bfc0a4 100644 --- a/google-cloud-firestore/src/main/java/com/google/cloud/firestore/Firestore.java +++ b/google-cloud-firestore/src/main/java/com/google/cloud/firestore/Firestore.java @@ -17,6 +17,7 @@ package com.google.cloud.firestore; import com.google.api.core.ApiFuture; +import com.google.api.core.InternalExtensionOnly; import com.google.api.gax.rpc.ApiStreamObserver; import com.google.cloud.Service; import java.util.List; @@ -24,6 +25,7 @@ import javax.annotation.Nullable; /** Represents a Firestore Database and is the entry point for all Firestore operations */ +@InternalExtensionOnly public interface Firestore extends Service, AutoCloseable { /**