From a41b07ea8a02aefb9f2798240dd7ba32589791fe Mon Sep 17 00:00:00 2001 From: Sebastian Schmidt Date: Tue, 26 Jan 2021 16:39:21 -0700 Subject: [PATCH] fix: don't throw NPE in DocumentSnapshot.getDate() when value is missing (#513) --- .../main/java/com/google/cloud/firestore/DocumentSnapshot.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/google-cloud-firestore/src/main/java/com/google/cloud/firestore/DocumentSnapshot.java b/google-cloud-firestore/src/main/java/com/google/cloud/firestore/DocumentSnapshot.java index 9edff880b..771389973 100644 --- a/google-cloud-firestore/src/main/java/com/google/cloud/firestore/DocumentSnapshot.java +++ b/google-cloud-firestore/src/main/java/com/google/cloud/firestore/DocumentSnapshot.java @@ -345,7 +345,8 @@ public Long getLong(@Nonnull String field) { */ @Nullable public Date getDate(@Nonnull String field) { - return ((Timestamp) get(field)).toDate(); + Timestamp timestamp = getTimestamp(field); + return timestamp == null ? null : timestamp.toDate(); } /**