Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
chore!: enable gapicv2 (#188)
* chore!: enable gapicv2 for firestore/v1beta1 API

Committer: @miraleung
PiperOrigin-RevId: 305537104

Source-Author: Google APIs <noreply@google.com>
Source-Date: Wed Apr 8 12:58:48 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 6f8350c0df231d7e742fa10dbf929f33047715c9
Source-Link: googleapis/googleapis@6f8350c

* chore!: enable gapicv2 for firestore/admin/v1 API

Committer: @miraleung

There are the following breaking changes due to the collection_id discrepancy between [1] and [2]

1. https://github.com/googleapis/googleapis/blob/6f8350c0df231d7e742fa10dbf929f33047715c9/google/firestore/admin/v1/firestore_gapic.yaml#L24-L29
2. https://github.com/googleapis/googleapis/blob/6f8350c0df231d7e742fa10dbf929f33047715c9/google/firestore/admin/v1/field.proto#L39
```
com.google.firestore.admin.v1.FieldName: Method 'public java.lang.String getCollectionId()' has been removed
com.google.firestore.admin.v1.FieldName: Method 'public java.lang.String getFieldId()' has been removed
com.google.firestore.admin.v1.FieldName$Builder: Method 'public java.lang.String getCollectionId()' has been removed
com.google.firestore.admin.v1.FieldName$Builder: Method 'public java.lang.String getFieldId()' has been removed
com.google.firestore.admin.v1.FieldName$Builder: Method 'public com.google.firestore.admin.v1.FieldName$Builder setCollectionId(java.lang.String)' has been removed
com.google.firestore.admin.v1.FieldName$Builder: Method 'public com.google.firestore.admin.v1.FieldName$Builder setFieldId(java.lang.String)' has been removed
com.google.firestore.admin.v1.IndexName: Method 'public java.lang.String getCollectionId()' has been removed
com.google.firestore.admin.v1.IndexName: Method 'public java.lang.String getIndexId()' has been removed
com.google.firestore.admin.v1.IndexName$Builder: Method 'public java.lang.String getCollectionId()' has been removed
com.google.firestore.admin.v1.IndexName$Builder: Method 'public java.lang.String getIndexId()' has been removed
com.google.firestore.admin.v1.IndexName$Builder: Method 'public com.google.firestore.admin.v1.IndexName$Builder setCollectionId(java.lang.String)' has been removed
com.google.firestore.admin.v1.IndexName$Builder: Method 'public com.google.firestore.admin.v1.IndexName$Builder setIndexId(java.lang.String)' has been removed
```

PiperOrigin-RevId: 305561114

Source-Author: Google APIs <noreply@google.com>
Source-Date: Wed Apr 8 14:57:39 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 0d69cddaa23b556e7299f84ad55a02ec1cad55a9
Source-Link: googleapis/googleapis@0d69cdd

* chore!: enable gapicv2 for firestore/v1 API

Note that this contains breaking Java changes:
  com.google.cloud.firestore.v1.FirestoreClient: Method 'public void deleteDocument(com.google.firestore.v1.AnyPathName)' has been removed

Committer: @miraleung
PiperOrigin-RevId: 305561906

Source-Author: Google APIs <noreply@google.com>
Source-Date: Wed Apr 8 15:01:42 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: d741cd976975c745d0199987aff0e908b8352992
Source-Link: googleapis/googleapis@d741cd9

* chore!: add clirr-ignored-differences.xml

BREAKING CHANGE: various renames due to generator changes

Renamed data model properties
* Usage of collectionId replaced with collection
* Usage of fieldId replaced with field
* Usage of indexId replaced with index
* Usage of ParentName replaced with CollectionGroupName
* Usage of AnyPathName replaced with String

Long running operation renames:
* FirestoreAdminClient#createIndex -> FirestoreAdminClient#createIndexAsync
* FirestoreAdminClient#exportDocuments -> FirestoreAdminClient#exportDocumentsAsync
* FirestoreAdminClient#importDocuments -> FirestoreAdminClient#importDocumentsAsync
* FirestoreAdminClient#updateField -> FirestoreAdminClient#updateFieldAsync

Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
  • Loading branch information
yoshi-automation and BenWhitehead committed Jul 21, 2020
1 parent 13edb36 commit 92224bc
Show file tree
Hide file tree
Showing 22 changed files with 2,989 additions and 2,162 deletions.
98 changes: 98 additions & 0 deletions google-cloud-firestore/clirr-ignored-differences.xml
Expand Up @@ -36,4 +36,102 @@
<method>*(com.google.cloud.firestore.FirestoreImpl, *)</method>
</difference>

<!--
createIndex -> createIndexAsync
-->
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
<method>com.google.longrunning.Operation createIndex(com.google.firestore.admin.v1.ParentName, com.google.firestore.admin.v1.Index)</method>
</difference>
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
<method>com.google.longrunning.Operation createIndex(java.lang.String, com.google.firestore.admin.v1.Index)</method>
</difference>
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
<method>com.google.longrunning.Operation createIndex(com.google.firestore.admin.v1.CreateIndexRequest)</method>
</difference>

<!--
exportDocuments -> exportDocumentsAsync
-->
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
<method>com.google.longrunning.Operation exportDocuments(com.google.firestore.admin.v1.DatabaseName)</method>
</difference>
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
<method>com.google.longrunning.Operation exportDocuments(java.lang.String)</method>
</difference>
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
<method>com.google.longrunning.Operation exportDocuments(com.google.firestore.admin.v1.ExportDocumentsRequest)</method>
</difference>
<!--
importDocuments -> importDocumentsAsync
-->
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
<method>com.google.longrunning.Operation importDocuments(com.google.firestore.admin.v1.DatabaseName)</method>
</difference>
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
<method>com.google.longrunning.Operation importDocuments(java.lang.String)</method>
</difference>
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
<method>com.google.longrunning.Operation importDocuments(com.google.firestore.admin.v1.ImportDocumentsRequest)</method>
</difference>
<!--
updatedField -> updateFieldAsync
-->
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
<method>com.google.longrunning.Operation updateField(com.google.firestore.admin.v1.Field)</method>
</difference>
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
<method>com.google.longrunning.Operation updateField(com.google.firestore.admin.v1.UpdateFieldRequest)</method>
</difference>
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
<method>com.google.longrunning.Operation updateField(com.google.firestore.admin.v1.UpdateFieldRequest)</method>
</difference>

<!--
deleteDocument(AnyPathName) -> deleteDocument(String)
-->
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/firestore/v1/FirestoreClient</className>
<method>void deleteDocument(com.google.firestore.v1.AnyPathName)</method>
</difference>
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/firestore/v1beta1/FirestoreClient</className>
<method>void deleteDocument(com.google.firestore.v1beta1.AnyPathName)</method>
</difference>

<!--
ParentName -> CollectionGroupName
-->
<difference>
<differenceType>7005</differenceType>
<className>com/google/cloud/firestore/v1/FirestoreAdminClient*</className>
<method>com.google.cloud.firestore.v1.FirestoreAdminClient$List*PagedResponse list*(com.google.firestore.admin.v1.ParentName)</method>
<to>com.google.cloud.firestore.v1.FirestoreAdminClient$List*PagedResponse list*(com.google.firestore.admin.v1.CollectionGroupName)</to>
</difference>

</differences>

0 comments on commit 92224bc

Please sign in to comment.