From 2a4a7b50d40ff1c165e3d359d5f4eaf929f6ffbc Mon Sep 17 00:00:00 2001
From: Brian Chen <chenbrian@google.com>
Date: Wed, 13 May 2020 13:37:04 -0700
Subject: [PATCH] fix: catch null Firestore in system tests (#215)

---
 .../java/com/google/cloud/firestore/it/ITQueryWatchTest.java  | 4 ++++
 .../test/java/com/google/cloud/firestore/it/ITSystemTest.java | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITQueryWatchTest.java b/google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITQueryWatchTest.java
index 69cf5cec8..cb9d69ec1 100644
--- a/google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITQueryWatchTest.java
+++ b/google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITQueryWatchTest.java
@@ -39,6 +39,7 @@
 import com.google.common.base.Joiner;
 import com.google.common.base.Joiner.MapJoiner;
 import com.google.common.base.Optional;
+import com.google.common.base.Preconditions;
 import com.google.common.base.Predicate;
 import com.google.common.collect.FluentIterable;
 import com.google.common.collect.Range;
@@ -83,6 +84,9 @@ public void before() {
 
   @AfterClass
   public static void afterClass() throws Exception {
+    Preconditions.checkNotNull(
+        firestore,
+        "Error instantiating Firestore. Check that the service account credentials were properly set.");
     firestore.close();
   }
 
diff --git a/google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java b/google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java
index 262478208..3c1bbb0e6 100644
--- a/google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java
+++ b/google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java
@@ -55,6 +55,7 @@
 import com.google.cloud.firestore.Transaction.Function;
 import com.google.cloud.firestore.WriteBatch;
 import com.google.cloud.firestore.WriteResult;
+import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
 import java.util.ArrayList;
@@ -104,6 +105,9 @@ public void before() {
 
   @After
   public void after() throws Exception {
+    Preconditions.checkNotNull(
+        firestore,
+        "Error instantiating Firestore. Check that the service account credentials were properly set.");
     firestore.close();
   }