From 0088ee7b1f0c5bb65d7636de77e2c7f9098978e9 Mon Sep 17 00:00:00 2001 From: Denver Coneybeare Date: Fri, 27 Mar 2020 15:33:47 -0400 Subject: [PATCH] feat: use SecureRandom instead of Random to reduce the chance of auto-id collisions (#156) --- .../main/java/com/google/cloud/firestore/FirestoreImpl.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreImpl.java b/google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreImpl.java index 830ae482f..77472d5f1 100644 --- a/google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreImpl.java +++ b/google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreImpl.java @@ -41,6 +41,7 @@ import io.opencensus.trace.Span; import io.opencensus.trace.Tracer; import io.opencensus.trace.Tracing; +import java.security.SecureRandom; import java.util.ArrayList; import java.util.HashMap; import java.util.List; @@ -57,7 +58,7 @@ */ class FirestoreImpl implements Firestore { - private static final Random RANDOM = new Random(); + private static final Random RANDOM = new SecureRandom(); private static final int AUTO_ID_LENGTH = 20; private static final String AUTO_ID_ALPHABET = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789";