From a426da16bce75da2c5daf7d97c63b6f71c7ed5c8 Mon Sep 17 00:00:00 2001 From: yoshi-automation Date: Fri, 16 Oct 2020 14:41:49 -0700 Subject: [PATCH 1/2] changes without context autosynth cannot find the source of changes triggered by earlier changes in this repository, or by version upgrades to tools such as linters. --- .github/CODEOWNERS | 6 ++++-- CONTRIBUTING.md | 14 ++++++-------- synth.metadata | 2 +- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index f2554d54..7b2a7ff1 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -4,7 +4,9 @@ # For syntax help see: # https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax -* @googleapis/api-logging @googleapis/yoshi-java +# The @googleapis/api-logging is the default owner for changes in this repo +* @googleapis/yoshi-java @googleapis/api-logging +**/*.java @googleapis/api-logging # The java-samples-reviewers team is the default owner for samples changes -samples/**/*.java @googleapis/api-logging @googleapis/java-samples-reviewers +samples/**/*.java @googleapis/java-samples-reviewers diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a9304f18..f2dbdee0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -31,14 +31,14 @@ This project follows To build, package, and run all unit tests run the command -```bash +``` mvn clean verify ``` ### Running Integration tests To include integration tests when building the project, you need access to -a GCP Project with a valid service account. +a GCP Project with a valid service account. For instructions on how to generate a service account and corresponding credentials JSON see: [Creating a Service Account][1]. @@ -57,15 +57,14 @@ Code Samples must be bundled in separate Maven modules, and guarded by a Maven profile with the name `enable-samples`. The samples must be separate from the primary project for a few reasons: - 1. Primary projects have a minimum Java version of Java 7 whereas samples have a minimum Java version of Java 8. Due to this we need the ability to selectively exclude samples from a build run. 2. Many code samples depend on external GCP services and need credentials to access the service. -3. Code samples are not released as Maven artifacts and must be excluded from +3. Code samples are not released as Maven artifacts and must be excluded from release builds. - + ### Building ```bash @@ -107,14 +106,13 @@ mvn -Penable-samples clean verify Code in this repo is formatted with [google-java-format](https://github.com/google/google-java-format). To run formatting on your project, you can run: - -```bash +``` mvn com.coveo:fmt-maven-plugin:format ``` ### Profile Activation -To include code samples when building and testing the project, enable the +To include code samples when building and testing the project, enable the `enable-samples` Maven profile. #### Command line diff --git a/synth.metadata b/synth.metadata index ea2acebd..22482ac6 100644 --- a/synth.metadata +++ b/synth.metadata @@ -4,7 +4,7 @@ "git": { "name": ".", "remote": "https://github.com/googleapis/java-errorreporting.git", - "sha": "c9cb50974d8c2fce2aeec3563a7f9800a32d5a25" + "sha": "5dfc3692aa05aca5d2ef54910d1170ff119cf8bb" } }, { From 52a37c2681ad12892f0705b8dcb03ee9aa328e30 Mon Sep 17 00:00:00 2001 From: yoshi-automation Date: Fri, 16 Oct 2020 14:45:56 -0700 Subject: [PATCH 2/2] chore: debrand 'Stackdriver' in favor of 'Cloud' in Error Reporting GAPIC libraries PiperOrigin-RevId: 337519886 Source-Author: Google APIs Source-Date: Fri Oct 16 09:27:07 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: e5211c547d63632963f9125e2b333185d57ff8f6 Source-Link: https://github.com/googleapis/googleapis/commit/e5211c547d63632963f9125e2b333185d57ff8f6 --- .../com/google/cloud/errorreporting/v1beta1/package-info.java | 2 +- .../errorreporting/v1beta1/stub/ErrorGroupServiceStub.java | 2 +- .../errorreporting/v1beta1/stub/ErrorStatsServiceStub.java | 2 +- .../v1beta1/stub/GrpcErrorGroupServiceCallableFactory.java | 2 +- .../v1beta1/stub/GrpcErrorGroupServiceStub.java | 2 +- .../v1beta1/stub/GrpcErrorStatsServiceCallableFactory.java | 2 +- .../v1beta1/stub/GrpcErrorStatsServiceStub.java | 2 +- .../v1beta1/stub/GrpcReportErrorsServiceCallableFactory.java | 2 +- .../v1beta1/stub/GrpcReportErrorsServiceStub.java | 2 +- .../errorreporting/v1beta1/stub/ReportErrorsServiceStub.java | 2 +- synth.metadata | 4 ++-- 11 files changed, 12 insertions(+), 12 deletions(-) diff --git a/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/package-info.java b/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/package-info.java index 2c9c6269..c36b4886 100644 --- a/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/package-info.java +++ b/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/package-info.java @@ -15,7 +15,7 @@ */ /** - * A client to Stackdriver Error Reporting API. + * A client to Cloud Error Reporting API. * *

The interfaces provided are listed below, along with usage samples. * diff --git a/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/ErrorGroupServiceStub.java b/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/ErrorGroupServiceStub.java index b658babd..0b84c327 100644 --- a/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/ErrorGroupServiceStub.java +++ b/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/ErrorGroupServiceStub.java @@ -25,7 +25,7 @@ // AUTO-GENERATED DOCUMENTATION AND CLASS /** - * Base stub class for Stackdriver Error Reporting API. + * Base stub class for Cloud Error Reporting API. * *

This class is for advanced usage and reflects the underlying API directly. */ diff --git a/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/ErrorStatsServiceStub.java b/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/ErrorStatsServiceStub.java index 65ec1b77..c5ecf049 100644 --- a/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/ErrorStatsServiceStub.java +++ b/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/ErrorStatsServiceStub.java @@ -31,7 +31,7 @@ // AUTO-GENERATED DOCUMENTATION AND CLASS /** - * Base stub class for Stackdriver Error Reporting API. + * Base stub class for Cloud Error Reporting API. * *

This class is for advanced usage and reflects the underlying API directly. */ diff --git a/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcErrorGroupServiceCallableFactory.java b/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcErrorGroupServiceCallableFactory.java index 4e3c3873..8588ba9d 100644 --- a/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcErrorGroupServiceCallableFactory.java +++ b/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcErrorGroupServiceCallableFactory.java @@ -36,7 +36,7 @@ // AUTO-GENERATED DOCUMENTATION AND CLASS /** - * gRPC callable factory implementation for Stackdriver Error Reporting API. + * gRPC callable factory implementation for Cloud Error Reporting API. * *

This class is for advanced usage. */ diff --git a/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcErrorGroupServiceStub.java b/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcErrorGroupServiceStub.java index ace5a10a..62d9e9c0 100644 --- a/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcErrorGroupServiceStub.java +++ b/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcErrorGroupServiceStub.java @@ -36,7 +36,7 @@ // AUTO-GENERATED DOCUMENTATION AND CLASS /** - * gRPC stub implementation for Stackdriver Error Reporting API. + * gRPC stub implementation for Cloud Error Reporting API. * *

This class is for advanced usage and reflects the underlying API directly. */ diff --git a/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcErrorStatsServiceCallableFactory.java b/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcErrorStatsServiceCallableFactory.java index a703a39d..e3937fca 100644 --- a/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcErrorStatsServiceCallableFactory.java +++ b/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcErrorStatsServiceCallableFactory.java @@ -36,7 +36,7 @@ // AUTO-GENERATED DOCUMENTATION AND CLASS /** - * gRPC callable factory implementation for Stackdriver Error Reporting API. + * gRPC callable factory implementation for Cloud Error Reporting API. * *

This class is for advanced usage. */ diff --git a/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcErrorStatsServiceStub.java b/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcErrorStatsServiceStub.java index 22ca7e25..876f7c9b 100644 --- a/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcErrorStatsServiceStub.java +++ b/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcErrorStatsServiceStub.java @@ -42,7 +42,7 @@ // AUTO-GENERATED DOCUMENTATION AND CLASS /** - * gRPC stub implementation for Stackdriver Error Reporting API. + * gRPC stub implementation for Cloud Error Reporting API. * *

This class is for advanced usage and reflects the underlying API directly. */ diff --git a/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcReportErrorsServiceCallableFactory.java b/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcReportErrorsServiceCallableFactory.java index c27d480d..bb50da7b 100644 --- a/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcReportErrorsServiceCallableFactory.java +++ b/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcReportErrorsServiceCallableFactory.java @@ -36,7 +36,7 @@ // AUTO-GENERATED DOCUMENTATION AND CLASS /** - * gRPC callable factory implementation for Stackdriver Error Reporting API. + * gRPC callable factory implementation for Cloud Error Reporting API. * *

This class is for advanced usage. */ diff --git a/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcReportErrorsServiceStub.java b/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcReportErrorsServiceStub.java index 5850e9d4..9f724c83 100644 --- a/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcReportErrorsServiceStub.java +++ b/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/GrpcReportErrorsServiceStub.java @@ -35,7 +35,7 @@ // AUTO-GENERATED DOCUMENTATION AND CLASS /** - * gRPC stub implementation for Stackdriver Error Reporting API. + * gRPC stub implementation for Cloud Error Reporting API. * *

This class is for advanced usage and reflects the underlying API directly. */ diff --git a/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/ReportErrorsServiceStub.java b/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/ReportErrorsServiceStub.java index bdf8854c..e61d6d3a 100644 --- a/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/ReportErrorsServiceStub.java +++ b/google-cloud-errorreporting/src/main/java/com/google/cloud/errorreporting/v1beta1/stub/ReportErrorsServiceStub.java @@ -24,7 +24,7 @@ // AUTO-GENERATED DOCUMENTATION AND CLASS /** - * Base stub class for Stackdriver Error Reporting API. + * Base stub class for Cloud Error Reporting API. * *

This class is for advanced usage and reflects the underlying API directly. */ diff --git a/synth.metadata b/synth.metadata index 22482ac6..cf95d826 100644 --- a/synth.metadata +++ b/synth.metadata @@ -11,8 +11,8 @@ "git": { "name": "googleapis", "remote": "https://github.com/googleapis/googleapis.git", - "sha": "fe312530ec0a99b1e7e498253573ff70f2c6c6cb", - "internalRef": "321573684" + "sha": "e5211c547d63632963f9125e2b333185d57ff8f6", + "internalRef": "337519886" } }, {