Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate GoogleJsonClientFeature configurations closer to google-api-client [requires gax] #939

Open
mpeddada1 opened this issue Dec 16, 2022 · 3 comments
Open

Relocate GoogleJsonClientFeature configurations closer to google-api-client [requires gax] #939

mpeddada1 opened this issue Dec 16, 2022 · 3 comments
Assignees
@kolea2
Labels
api: datastore Issues related to the googleapis/java-datastore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@mpeddada1
Copy link
Contributor

Configurations related to google-api-client and google-http-client are currently present in gax-java. Libraries like java-datastore contain modules that bring in the google-api-client dependency but not gax so they aren't able to take advantage of these configs and as a result, have to add some of these configurations on their own. Reference: #928
@mpeddada1 mpeddada1 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: datastore Issues related to the googleapis/java-datastore API. labels Dec 16, 2022
@mpeddada1 mpeddada1 changed the title Relocate GoogleJsonClientFeature confiigurations closer to google-api-client Relocate GoogleJsonClientFeature configurations closer to google-api-client Dec 16, 2022
@meredithslota
Copy link

@mpeddada1 Thank you for filing this — we have a proposal to refactor this library to use gax-java but it was tabled a few years ago because of bandwidth constraints. I will share it with you.

@mpeddada1
Copy link
Contributor Author

Thank you for the reference @meredithslota!

@meredithslota meredithslota changed the title Relocate GoogleJsonClientFeature configurations closer to google-api-client Relocate GoogleJsonClientFeature configurations closer to google-api-client [requires gax] Mar 7, 2023
@meredithslota
Copy link

FYI we are actively prioritizing this now, in combination with other efforts related to upgrading this library to use gax-java (cc: @jainsahab and @kolea2).

@jainsahab jainsahab assigned kolea2 and unassigned jainsahab Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kolea2 kolea2

Labels
api: datastore Issues related to the googleapis/java-datastore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@meredithslota @jainsahab @kolea2 @mpeddada1