Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove error_prone_annotations exclusion rules from poms #31

Merged
merged 1 commit into from Feb 5, 2020

Conversation

athakor
Copy link
Contributor

@athakor athakor commented Jan 31, 2020

Fixes #30

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 31, 2020
@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #31 into master will decrease coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #31      +/-   ##
============================================
- Coverage     59.72%   59.44%   -0.28%     
- Complexity      378      384       +6     
============================================
  Files            46       46              
  Lines          2262     2286      +24     
  Branches        247      251       +4     
============================================
+ Hits           1351     1359       +8     
- Misses          804      820      +16     
  Partials        107      107
Impacted Files Coverage Δ Complexity Δ
...main/java/com/google/cloud/datastore/GqlQuery.java 30.76% <0%> (-0.44%) 5% <0%> (ø)
...java/com/google/cloud/datastore/DatastoreImpl.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...a/com/google/cloud/datastore/QueryResultsImpl.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...in/java/com/google/cloud/datastore/KeyFactory.java 100% <0%> (ø) 10% <0%> (+3%) ⬆️
...ain/java/com/google/cloud/datastore/BatchImpl.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...va/com/google/cloud/datastore/TransactionImpl.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...cloud/datastore/testing/RemoteDatastoreHelper.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...va/com/google/cloud/datastore/StructuredQuery.java 71.46% <0%> (+0.07%) 23% <0%> (ø) ⬇️
.../main/java/com/google/cloud/datastore/BaseKey.java 89.55% <0%> (+0.15%) 14% <0%> (ø) ⬇️
...java/com/google/cloud/datastore/IncompleteKey.java 88.09% <0%> (+0.29%) 9% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4481c27...53d83c5. Read the comment docs.

@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 5, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 5, 2020
@BenWhitehead BenWhitehead merged commit b659cfa into googleapis:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Temporary error_prone_annotations exclusion rules from poms
4 participants