Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary animal-sniffer-annotations exclusion rules in poms #3

Closed
BenWhitehead opened this issue Dec 19, 2019 · 0 comments · Fixed by #16
Closed

Temporary animal-sniffer-annotations exclusion rules in poms #3

BenWhitehead opened this issue Dec 19, 2019 · 0 comments · Fixed by #16
Assignees
@athakor
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@BenWhitehead
Copy link
Collaborator

As of grpc-api:1.26.0 and guava:28.1-android there is a failure for animal-sniffer-annotations

There is no actual difference between the single annotation present in the versions, so it is being excluded for the time being.

The exclusion should be removed from the poms when there is no longer a disparity.
@athakor athakor self-assigned this Jan 7, 2020
@athakor athakor mentioned this issue Jan 7, 2020
Merged
BenWhitehead pushed a commit that referenced this issue Jan 9, 2020
@athakor @BenWhitehead
fix: remove temporary added animal-sniffer-annotations exclusion rule…
fde0a9f 
… from pom (#16)


| Package | Update | Change |
|---|---|---|
| com.google.guava:guava-bom | minor | `28.1-android` -> `28.2-android` |

The new version of Guava no longer has a dependency on `org.codehaus.mojo:animal-sniffer-annotations`
Fixes #3
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athakor athakor

Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: update dependency com.google.guava:guava-bom to v28.2-android athakor/java-datastore
3 participants
@BenWhitehead @yoshi-automation @athakor