Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: QueryResults return startCursor if specified #207

Merged
merged 1 commit into from Aug 27, 2020
Merged

fix: QueryResults return startCursor if specified #207

merged 1 commit into from Aug 27, 2020

Conversation

athakor
Copy link
Contributor

@athakor athakor commented Aug 20, 2020

Fixes #204

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 20, 2020
@athakor athakor changed the title https://github.com/googleapis/java-datastore/issues/204 fix: QueryResults return startCursor if specified Aug 20, 2020
@codecov
Copy link

codecov bot commented Aug 20, 2020 •
edited

Codecov Report

Merging #207 into master will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #207      +/-   ##
============================================
+ Coverage     56.69%   56.74%   +0.04%     
  Complexity      384      384              
============================================
  Files            48       48              
  Lines          2397     2395       -2     
  Branches        266      265       -1     
============================================
  Hits           1359     1359              
+ Misses          931      929       -2     
  Partials        107      107
Impacted Files Coverage Δ Complexity Δ
...a/com/google/cloud/datastore/QueryResultsImpl.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d188c4c...cf357db. Read the comment docs.

@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/java-datastore API. label Aug 21, 2020
@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2020
@athakor
Copy link
Contributor Author

athakor commented Aug 27, 2020

@BenWhitehead PTAL

@BenWhitehead BenWhitehead merged commit 023229a into googleapis:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/java-datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Queries that start at a cursor report that they start at the very beginning until you go to the first element
3 participants
@athakor @BenWhitehead @yoshi-kokoro