Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fromPb constructors public #1006

Open
frekw opened this issue Mar 2, 2023 · 0 comments
Open

Make fromPb constructors public #1006

frekw opened this issue Mar 2, 2023 · 0 comments
Labels
api: datastore Issues related to the googleapis/java-datastore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@frekw
Copy link

frekw commented Mar 2, 2023

Is your feature request related to a problem? Please describe.
I often run across situations where I have either a com.google.datastore.v1.Key or com.google.datastore.v1.Entity and would like to transform it into a com.google.cloud.datastore.[Key|Entity]. There currently exists fromPb constructors within this codebase, but they are not accessible outside of the com.google.datastore namespace.

Describe the solution you'd like
Making the public.

Describe alternatives you've considered
I currently have two interop packages of my own living in com.google.datastore that re-export these methods. It works but isn't great.
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/java-datastore API. label Mar 2, 2023
@frekw frekw mentioned this issue Mar 2, 2023
Open
@meredithslota meredithslota added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/java-datastore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frekw @meredithslota