Skip to content
This repository has been archived by the owner on Dec 3, 2023. It is now read-only.

fix: verify correctness of map -> list equality #174

Merged
merged 3 commits into from Mar 10, 2020
Merged

Conversation

frankyn
Copy link
Member

@frankyn frankyn commented Mar 10, 2020

Fixes #173

@frankyn frankyn requested a review from chingor13 March 10, 2020 17:47
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 10, 2020
@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #174 into master will increase coverage by 58.52%.
The diff coverage is 54.54%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #174       +/-   ##
=============================================
+ Coverage      9.23%   67.76%   +58.52%     
- Complexity       32      378      +346     
=============================================
  Files            36       36               
  Lines          1959     1967        +8     
  Branches        254      259        +5     
=============================================
+ Hits            181     1333     +1152     
+ Misses         1766      526     -1240     
- Partials         12      108       +96
Impacted Files Coverage Δ Complexity Δ
...ud-core/src/main/java/com/google/cloud/Policy.java 92.07% <54.54%> (+92.07%) 20 <0> (+20) ⬆️
...a/com/google/cloud/testing/BaseEmulatorHelper.java 31.39% <0%> (+31.39%) 5% <0%> (+5%) ⬆️
...c/main/java/com/google/cloud/BaseWriteChannel.java 36.5% <0%> (+36.5%) 18% <0%> (+18%) ⬆️
...src/main/java/com/google/cloud/ServiceOptions.java 43.42% <0%> (+43.42%) 32% <0%> (+32%) ⬆️
...core/src/main/java/com/google/cloud/ByteArray.java 46.66% <0%> (+46.66%) 12% <0%> (+12%) ⬆️
...re/src/main/java/com/google/cloud/RetryHelper.java 53.84% <0%> (+53.84%) 2% <0%> (+2%) ⬆️
.../src/main/java/com/google/cloud/NoCredentials.java 60% <0%> (+60%) 4% <0%> (+4%) ⬆️
...-core/src/main/java/com/google/cloud/PageImpl.java 61.11% <0%> (+61.11%) 8% <0%> (+8%) ⬆️
...re/src/main/java/com/google/cloud/BaseService.java 62.5% <0%> (+62.5%) 2% <0%> (+2%) ⬆️
.../src/main/java/com/google/cloud/AsyncPageImpl.java 64.28% <0%> (+64.28%) 2% <0%> (+2%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d28f885...f6ed440. Read the comment docs.

@chingor13 chingor13 changed the title Verify correctness of map -> list equality fix: verify correctness of map -> list equality Mar 10, 2020
@frankyn frankyn merged commit f45d913 into master Mar 10, 2020
@frankyn frankyn deleted the fix-list-equality branch March 10, 2020 18:46
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 10, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
### [1.93.2](https://www.github.com/googleapis/java-core/compare/v1.93.1...v1.93.2) (2020-03-10)


### Bug Fixes

* verify correctness of map -> list equality ([#174](https://www.github.com/googleapis/java-core/issues/174)) ([f45d913](https://www.github.com/googleapis/java-core/commit/f45d9131d5d2bbb2cc4cec67ebe82054fda58f55))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Policy equality fails for binding list order
3 participants