Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

Classes in Java artifact do not match the protos shipped with it #134

Closed
thesamet opened this issue Mar 28, 2021 · 6 comments · Fixed by #169
Closed

Classes in Java artifact do not match the protos shipped with it #134

thesamet opened this issue Mar 28, 2021 · 6 comments · Fixed by #169
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@thesamet
Copy link

thesamet commented Mar 28, 2021

In the 2.1.0 jar, google/api/endpoint.proto contains a repeated string features = 4, however the corresponding Java class file doesn't have any of the methods corresponding to this field.

Steps to reproduce

$ mkdir tmp && cd tmp
$ curl https://repo1.maven.org/maven2/com/google/api/grpc/proto-google-common-protos/2.1.0/proto-google-common-protos-2.1.0.jar -O
$ less google/api/endpoint.proto   # observe Endpoint has a field features
$ javap  com.google.api.Endpoint | grep -i feature | wc -l
0 

It looks like getters for features are not there. Seemingly the code has been generated with a different version of the protos.

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Mar 29, 2021
@Neenu1995 Neenu1995 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 29, 2021
@chingor13
Copy link
Contributor

Thanks for bringing this to our attention. Our automation to update the generated code is not correctly copying the associated proto files with it.

@chingor13
Copy link
Contributor

chingor13 commented Mar 29, 2021

FYI, the removal of this field was in #35 and caused this library to go to 2.0.0

@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Mar 30, 2021
@Tochemey
Copy link

Tochemey commented Apr 8, 2021

@chingor13 Is there any update on this? Thanks

@virusdave
Copy link

Seconding the question on updates.

@Tochemey
Copy link

@chingor13 is there any good news upcoming on this ticket? Thanks

@gajones155
Copy link

@chingor13 I'm seeing the same issue with the latest 2.2.1 release where com/google/api/Visibility.class exists but there's no corresponding google/api/visibility.proto.

gcf-merge-on-green bot pushed a commit that referenced this issue May 20, 2021
The proto files were not in sync with the java files shipped with the artidact Id. 
Now the protos get copied directly from googleapis to java-common-protos repo to keep them in sync with each other.

Fixes #134
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants