feat: add CMEK Support #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
the
api: bigtable
google-cla
bot
added
the
cla: yes
This comment has been minimized.
This comment has been minimized.
kolea2
requested changes
Mar 3, 2021
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/Backup.java
Outdated
Show resolved
Hide resolved
...e-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/EncryptionInfo.java
Outdated
Show resolved
Hide resolved
proto-google-cloud-bigtable-admin-v2/clirr-ignored-differences.xml
Outdated
Show resolved
Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/Cluster.java
Outdated
Show resolved
Hide resolved
...d-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateClusterRequest.java
Outdated
Show resolved
Hide resolved
...-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateInstanceRequest.java
Outdated
Show resolved
Hide resolved
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableCmekIT.java
Outdated
Show resolved
Hide resolved
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableCmekIT.java
Outdated
Show resolved
Hide resolved
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableCmekIT.java
Outdated
Show resolved
Hide resolved
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableCmekIT.java
Outdated
Show resolved
Hide resolved
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/BackupTest.java
Outdated
Show resolved
Hide resolved
kolea2
requested changes
Mar 11, 2021
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableCmekIT.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #656 +/- ##
============================================
+ Coverage 83.55% 83.64% +0.09%
- Complexity 1198 1220 +22
============================================
Files 110 112 +2
Lines 7309 7417 +108
Branches 383 394 +11
============================================
+ Hits 6107 6204 +97
- Misses 1004 1010 +6
- Partials 198 203 +5
Continue to review full report at Codecov.
|
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
google-cla
bot
added
cla: no
google-cla
bot
added
cla: yes
10 tasks
5 tasks
ad548
force-pushed
the
cmek
branch
2 times, most recently
from
dbc629b
to
36d345b
Compare
kolea2
added
kokoro:force-run
kolea2
requested changes
Mar 31, 2021
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableCmekIT.java
Outdated
Show resolved
Hide resolved
Change-Id: I423410fd4b78cd31f646130316b88e7be7cd71ad
Change-Id: I1a68ffa9a83926e6f98273425332fec8503f976a
kolea2
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Change-Id: I5e38cf3ea2863eaa8c82643bded46b9b63699231
Change-Id: I34b3d5e0f0b1de8935c46a9497dc5c0e242f1c94
Change-Id: I59dee549d9ca79def4e41ab3bcc1f5126c9631af
kolea2
approved these changes
Apr 6, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 7, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.22.0](https://www.github.com/googleapis/java-bigtable/compare/v1.21.3...v1.22.0) (2021-04-06) ### Features * add CMEK Support ([#656](https://www.github.com/googleapis/java-bigtable/issues/656)) ([2821902](https://www.github.com/googleapis/java-bigtable/commit/2821902b34ae04596771a9fc5e2b62d5c24a7253)) ### Dependencies * update autovalue.version to v1.8 ([#703](https://www.github.com/googleapis/java-bigtable/issues/703)) ([13e7796](https://www.github.com/googleapis/java-bigtable/commit/13e7796d96222fe0181771d160d12a3da7f0a7a7)) * update dependency com.google.truth.extensions:truth-proto-extension to v1.1.2 ([#704](https://www.github.com/googleapis/java-bigtable/issues/704)) ([3fa8b00](https://www.github.com/googleapis/java-bigtable/commit/3fa8b0069d58a5705f11fac481ddcd4ad7d447f4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#673
Summary
All data at rest is typically encrypted with Google's default encryption. This feature will provide support for Customer Managed Encryption Keys (CMEK) in the JAVA client, allowing users to control their encryption keys. CMEK data at rest is protected using an encryption key that users control and manage through Cloud Key Management Service (Cloud KMS).
Checklist
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: