feat: Implement toString for Bigtable*Settings

[dmitry-fa]

Example of output from toString():

BigtableInstanceAdminSettings{
projectId=our-project-212, 
createInstanceSettings=UnaryCallSettings{retryableCodes=[], retrySettings=RetrySettings{totalTimeout=PT5M, initialRetryDelay=PT0S, retryDelayMultiplier=1.0, maxRetryDelay=PT0S, maxAttempts=0, jittered=true, 
initialRpcTimeout=PT5M, rpcTimeoutMultiplier=1.0, maxRpcTimeout=PT5M}},
createInstanceOperationSettings=com.google.api.gax.rpc.OperationCallSettings@3796751b,
getInstanceSettings=UnaryCallSettings{retryableCodes=[DEADLINE_EXCEEDED, UNAVAILABLE], retrySettings=RetrySettings{totalTimeout=PT10M, initialRetryDelay=PT1S, retryDelayMultiplier=2.0, maxRetryDelay=PT1M,
maxAttempts=0, jittered=true, initialRpcTimeout=PT1M, rpcTimeoutMultiplier=1.0, maxRpcTimeout=PT1M}},
listInstancesSettings=UnaryCallSettings{retryableCodes=[DEADLINE_EXCEEDED, UNAVAILABLE],
retrySettings=RetrySettings{totalTimeout=PT10M, initialRetryDelay=PT1S, retryDelayMultiplier=2.0, maxRetryDelay=PT1M, 
maxAttempts=0, jittered=true, initialRpcTimeout=PT1M, rpcTimeoutMultiplier=1.0, maxRpcTimeout=PT1M}}, 
partialUpdateInstanceSettings=UnaryCallSettings{retryableCodes=[DEADLINE_EXCEEDED, UNAVAILABLE], 
retrySettings=RetrySettings{totalTimeout=PT10M, initialRetryDelay=PT1S, retryDelayMultiplier=2.0, maxRetryDelay=PT1M, 
maxAttempts=0, jittered=true, initialRpcTimeout=PT1M, rpcTimeoutMultiplier=1.0, maxRpcTimeout=PT1M}}, 
partialUpdateInstanceOperationSettings=com.google.api.gax.rpc.OperationCallSettings@67b64c45, 
deleteInstanceSettings=UnaryCallSettings{retryableCodes=[], retrySettings=RetrySettings{totalTimeout=PT1M, 
initialRetryDelay=PT0S, retryDelayMultiplier=1.0, maxRetryDelay=PT0S, maxAttempts=0, jittered=true, initialRpcTimeout=PT1M, 
rpcTimeoutMultiplier=1.0, maxRpcTimeout=PT1M}}, createClusterSettings=UnaryCallSettings{retryableCodes=[], 
retrySettings=RetrySettings{totalTimeout=PT1M, initialRetryDelay=PT0S, retryDelayMultiplier=1.0, maxRetryDelay=PT0S, 
maxAttempts=0, jittered=true, initialRpcTimeout=PT1M, rpcTimeoutMultiplier=1.0, maxRpcTimeout=PT1M}}, 
createClusterOperationSettings=com.google.api.gax.rpc.OperationCallSettings@4411d970, 
getClusterSettings=UnaryCallSettings{retryableCodes=[DEADLINE_EXCEEDED, UNAVAILABLE], 
retrySettings=RetrySettings{totalTimeout=PT10M, initialRetryDelay=PT1S, retryDelayMultiplier=2.0, maxRetryDelay=PT1M, 
maxAttempts=0, jittered=true, initialRpcTimeout=PT1M, rpcTimeoutMultiplier=1.0, maxRpcTimeout=PT1M}}, 
listClustersSettings=UnaryCallSettings{retryableCodes=[DEADLINE_EXCEEDED, UNAVAILABLE], 
retrySettings=RetrySettings{totalTimeout=PT10M, initialRetryDelay=PT1S, retryDelayMultiplier=2.0, maxRetryDelay=PT1M, 
maxAttempts=0, jittered=true, initialRpcTimeout=PT1M, rpcTimeoutMultiplier=1.0, maxRpcTimeout=PT1M}}, 
updateClusterSettings=UnaryCallSettings{retryableCodes=[DEADLINE_EXCEEDED, UNAVAILABLE], 
retrySettings=RetrySettings{totalTimeout=PT10M, initialRetryDelay=PT1S, retryDelayMultiplier=2.0, maxRetryDelay=PT1M, 
maxAttempts=0, jittered=true, initialRpcTimeout=PT1M, rpcTimeoutMultiplier=1.0, maxRpcTimeout=PT1M}}, 
updateClusterOperationSettings=com.google.api.gax.rpc.OperationCallSettings@6442b0a6, 
deleteClusterSettings=UnaryCallSettings{retryableCodes=[], retrySettings=RetrySettings{totalTimeout=PT1M, 
initialRetryDelay=PT0S, retryDelayMultiplier=1.0, maxRetryDelay=PT0S, maxAttempts=0, jittered=true, initialRpcTimeout=PT1M, 
rpcTimeoutMultiplier=1.0, maxRpcTimeout=PT1M}}, createAppProfileSettings=UnaryCallSettings{retryableCodes=[], 
retrySettings=RetrySettings{totalTimeout=PT1M, initialRetryDelay=PT0S, retryDelayMultiplier=1.0, maxRetryDelay=PT0S, 
maxAttempts=0, jittered=true, initialRpcTimeout=PT1M, rpcTimeoutMultiplier=1.0, maxRpcTimeout=PT1M}}, 
getAppProfileSettings=UnaryCallSettings{retryableCodes=[DEADLINE_EXCEEDED, UNAVAILABLE], 
retrySettings=RetrySettings{totalTimeout=PT10M, initialRetryDelay=PT1S, retryDelayMultiplier=2.0, maxRetryDelay=PT1M, 
maxAttempts=0, jittered=true, initialRpcTimeout=PT1M, rpcTimeoutMultiplier=1.0, maxRpcTimeout=PT1M}}, 
listAppProfilesSettings=PagedCallSettings{retryableCodes=[DEADLINE_EXCEEDED, UNAVAILABLE], 
retrySettings=RetrySettings{totalTimeout=PT10M, initialRetryDelay=PT1S, retryDelayMultiplier=2.0, maxRetryDelay=PT1M, 
maxAttempts=0, jittered=true, initialRpcTimeout=PT1M, rpcTimeoutMultiplier=1.0, maxRpcTimeout=PT1M}}, 
updateAppProfileSettings=UnaryCallSettings{retryableCodes=[DEADLINE_EXCEEDED, UNAVAILABLE], 
retrySettings=RetrySettings{totalTimeout=PT10M, initialRetryDelay=PT1S, retryDelayMultiplier=2.0, maxRetryDelay=PT1M, 
maxAttempts=0, jittered=true, initialRpcTimeout=PT1M, rpcTimeoutMultiplier=1.0, maxRpcTimeout=PT1M}}, 
updateAppProfileOperationSettings=com.google.api.gax.rpc.OperationCallSettings@60f82f98, 
deleteAppProfileSettings=UnaryCallSettings{retryableCodes=[], retrySettings=RetrySettings{totalTimeout=PT1M, 
initialRetryDelay=PT0S, retryDelayMultiplier=1.0, maxRetryDelay=PT0S, maxAttempts=0, jittered=true, initialRpcTimeout=PT1M, 
rpcTimeoutMultiplier=1.0, maxRpcTimeout=PT1M}}, getIamPolicySettings=UnaryCallSettings{retryableCodes=
[DEADLINE_EXCEEDED, UNAVAILABLE], retrySettings=RetrySettings{totalTimeout=PT10M, initialRetryDelay=PT1S, 
retryDelayMultiplier=2.0, maxRetryDelay=PT1M, maxAttempts=0, jittered=true, initialRpcTimeout=PT1M, 
rpcTimeoutMultiplier=1.0, maxRpcTimeout=PT1M}}, setIamPolicySettings=UnaryCallSettings{retryableCodes=[], 
retrySettings=RetrySettings{totalTimeout=PT1M, initialRetryDelay=PT0S, retryDelayMultiplier=1.0, maxRetryDelay=PT0S, 
maxAttempts=0, jittered=true, initialRpcTimeout=PT1M, rpcTimeoutMultiplier=1.0, maxRpcTimeout=PT1M}}, 
testIamPermissionsSettings=UnaryCallSettings{retryableCodes=[DEADLINE_EXCEEDED, UNAVAILABLE], 
retrySettings=RetrySettings{totalTimeout=PT10M, initialRetryDelay=PT1S, retryDelayMultiplier=2.0, maxRetryDelay=PT1M, 
maxAttempts=0, jittered=true, initialRpcTimeout=PT1M, rpcTimeoutMultiplier=1.0, maxRpcTimeout=PT1M}}, 
stubSettings=BigtableInstanceAdminStubSettings{executorProvider=InstantiatingExecutorProvider{executorThreadCount=4, 
threadFactory=com.google.api.gax.core.InstantiatingExecutorProvider$1@35f983a6}, 
transportChannelProvider=com.google.api.gax.grpc.InstantiatingGrpcChannelProvider@7f690630, 
credentialsProvider=GoogleCredentialsProvider{scopesToApply=[https://www.googleapis.com/auth/bigtable.admin, 
https://www.googleapis.com/auth/bigtable.admin.cluster, https://www.googleapis.com/auth/bigtable.admin.instance, 
https://www.googleapis.com/auth/bigtable.admin.table, https://www.googleapis.com/auth/cloud-bigtable.admin, 
https://www.googleapis.com/auth/cloud-bigtable.admin.cluster, https://www.googleapis.com/auth/cloud-bigtable.admin.table, 
https://www.googleapis.com/auth/cloud-platform, https://www.googleapis.com/auth/cloud-platform.read-only], 
jwtEnabledScopes=[], OAuth2Credentials=null}, headerProvider=com.google.api.gax.rpc.NoHeaderProvider@edf4efb, 
internalHeaderProvider=com.google.api.gax.rpc.ApiClientHeaderProvider@2f7a2457, 
clock=com.google.api.core.NanoClock@566776ad, endpoint=bigtableadmin.googleapis.com:443, quotaProjectId=null, 
streamWatchdogProvider=com.google.api.gax.rpc.InstantiatingWatchdogProvider@6108b2d7, 
streamWatchdogCheckInterval=PT10S, tracerFactory=com.google.api.gax.tracing.NoopApiTracerFactory@1554909b}}

Fixes #233

[codecov]

Codecov Report

Merging #488 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #488      +/-   ##
============================================
+ Coverage     81.11%   81.31%   +0.19%     
- Complexity     1124     1128       +4     
============================================
  Files           106      106              
  Lines          6965     7042      +77     
  Branches        368      368              
============================================
+ Hits           5650     5726      +76     
- Misses         1117     1119       +2     
+ Partials        198      197       -1     

Impacted Files	Coverage Δ	Complexity Δ
...gtable/admin/v2/BigtableInstanceAdminSettings.java	98.24% <100.00%> (+1.69%)	7.00 <1.00> (+1.00)
.../bigtable/admin/v2/BigtableTableAdminSettings.java	77.01% <100.00%> (+13.37%)	9.00 <1.00> (+1.00)
...e/cloud/bigtable/data/v2/BigtableDataSettings.java	71.83% <100.00%> (+0.40%)	8.00 <1.00> (+1.00)
...ble/data/v2/stub/EnhancedBigtableStubSettings.java	97.60% <100.00%> (+0.16%)	22.00 <1.00> (+1.00)
...om/google/cloud/bigtable/emulator/v2/Emulator.java	59.83% <0.00%> (-0.82%)	14.00% <0.00%> (ø%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc74164...c4aec8f. Read the comment docs.

[igorbernstein2]

This looks mostly good. As a follow up, can you open a PR in gax to add meaningful toString impl for:

• InstantiatingExecutorProvider
• OperationCallSettings
• InstantiatingGrpcChannelProvider
• NoHeaderProvider
• InstantiatingWatchdogProvider
• etc

[dmitry-fa]

@igorbernstein2 the issue filed: googleapis/gax-java#1228

[igorbernstein2]

Please rebase and I'll merge the PR

[dmitry-fa]

Please rebase and I'll merge the PR

done

dismissed