Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update core dependencies for google-cloud-core and gax #240

Merged
merged 2 commits into from Apr 7, 2020
Merged

deps: update core dependencies for google-cloud-core and gax #240

merged 2 commits into from Apr 7, 2020

Conversation

kolea2
Copy link
Collaborator

@kolea2 kolea2 commented Apr 7, 2020 •
edited

Opening in favor of #238

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 7, 2020
@codecov
Copy link

codecov bot commented Apr 7, 2020 •
edited

Codecov Report

Merging #240 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #240   +/-   ##
=========================================
  Coverage     79.50%   79.50%           
  Complexity      960      960           
=========================================
  Files            99       99           
  Lines          6056     6056           
  Branches        318      318           
=========================================
  Hits           4815     4815           
  Misses         1049     1049           
  Partials        192      192

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86fab5c...f641ca1. Read the comment docs.

igorbernstein2
igorbernstein2 approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kolea2 kolea2 merged commit 8f384f4 into googleapis:master Apr 7, 2020
yoshi-automation added a commit that referenced this pull request Apr 9, 2020
@yoshi-automation
deps: update core dependencies for google-cloud-core and gax (#240)
9558ad4 
Source-Repo: googleapis/java-bigtable
Source-Sha: 8f384f4
Source-Link: 8f384f4
Author: kolea2 <45548808+kolea2@users.noreply.github.com>
Date: Tue Apr 7 12:36:35 2020 -0400
Original-Commit-Message: deps: update core dependencies for google-cloud-core and gax (#240)

* deps: update core dependencies for google-cloud-core and gax

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kolea2 @igorbernstein2 @googlebot