Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add row exists api #190

Merged
merged 3 commits into from Feb 5, 2020
Merged

feat: add row exists api #190

merged 3 commits into from Feb 5, 2020

Conversation

rahulKQL
Copy link
Contributor

@rahulKQL rahulKQL commented Feb 5, 2020

Fixes #188

Adding a new Row exists() API in BigtableDataClient

@rahulKQL
feat: add row exists api
4590966 
Adding a new Row exists() API in `BigtableDataClient`
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 5, 2020
@codecov
Copy link

codecov bot commented Feb 5, 2020 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@3235a97). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #190   +/-   ##
=========================================
  Coverage          ?   82.05%           
  Complexity        ?      978           
=========================================
  Files             ?       99           
  Lines             ?     6035           
  Branches          ?      332           
=========================================
  Hits              ?     4952           
  Misses            ?      907           
  Partials          ?      176
Impacted Files Coverage Δ Complexity Δ
...gle/cloud/bigtable/data/v2/BigtableDataClient.java 93.54% <100%> (ø) 39 <4> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3235a97...d1f00e8. Read the comment docs.

@rahulKQL rahulKQL marked this pull request as ready for review February 5, 2020 20:33
igorbernstein2
igorbernstein2 approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@igorbernstein2 igorbernstein2 merged commit d141c3d into googleapis:master Feb 5, 2020
@yoshi-automation yoshi-automation mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

@kolea2 kolea2 Awaiting requested review from kolea2

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add row exists API
3 participants
@rahulKQL @igorbernstein2 @googlebot