feat: introduce google-cloud-bigtable-deps-bom #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all of the dependency version management out of the root pom and into a separate BOM. This will allow java-bigtable-hbase to sync on dependency versions with java-bigtable
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #130 +/- ##
=========================================
Coverage 81.25% 81.25%
Complexity 940 940
=========================================
Files 96 96
Lines 5878 5878
Branches 327 327
=========================================
Hits 4776 4776
Misses 924 924
Partials 178 178Continue to review full report at Codecov.
|
kolea2
reviewed
Dec 30, 2019
|
CC @chingor13 to see if there are any last thoughts before I approve here |
kolea2
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all of the dependency version management out of the root pom and into a separate BOM.
This will allow java-bigtable-hbase to sync on dependency versions with java-bigtable.
In addition to moving the dependencyManagement section to a BOM, I imported
google-auth-library-bomand fixed the README to point to the correct version of gRPC