Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ARM support for gcloud bigtable emulator #1094

Merged
merged 2 commits into from Dec 16, 2021

Conversation

rameshdharan
Copy link
Contributor

No description provided.

@rameshdharan rameshdharan requested review from a team as code owners December 7, 2021 03:37
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Dec 7, 2021
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but lets wait for the sdk to rollout

@rameshdharan
Copy link
Contributor Author

lgtm, but lets wait for the sdk to rollout

SDK with the ARM components has now rolled out:
https://cloud.google.com/sdk/docs/release-notes#36700_2021-12-14

@igorbernstein2 igorbernstein2 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 14, 2021
@igorbernstein2
Copy link
Contributor

I tried this on my personal m1, and it failed to download the binaries. I havent had a chance to debug, but we should wait to merge

@igorbernstein2 igorbernstein2 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 16, 2021
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@igorbernstein2 igorbernstein2 added the automerge Merge the pull request once unit tests and other checks pass. label Dec 16, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit d3cb4a4 into googleapis:main Dec 16, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 16, 2021
@sap1ens
Copy link

sap1ens commented Jan 4, 2022

Hey folks, thanks for doing this! When should we expect a new release of the library including this change?

gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 5, 2022
mutianf pushed a commit to mutianf/java-bigtable that referenced this pull request Mar 18, 2022
mutianf pushed a commit to mutianf/java-bigtable that referenced this pull request Mar 18, 2022
🤖 I have created a release \*beep\* \*boop\*
---
## [2.5.0](https://www.github.com/googleapis/java-bigtable/compare/v2.4.0...v2.5.0) (2022-01-05)


### Features

* add batch throttled ms metric ([googleapis#888](https://www.github.com/googleapis/java-bigtable/issues/888)) ([0d197a5](https://www.github.com/googleapis/java-bigtable/commit/0d197a5ab9b7ccd20091c1c6c4a794586d6a51dc))
* ARM support for gcloud bigtable emulator ([googleapis#1094](https://www.github.com/googleapis/java-bigtable/issues/1094)) ([d3cb4a4](https://www.github.com/googleapis/java-bigtable/commit/d3cb4a4e03ae0f7e065bfee06ac8e3b86b447a4a))


### Bug Fixes

* align ip version preference for the wrapped  emulator ([googleapis#1052](https://www.github.com/googleapis/java-bigtable/issues/1052)) ([9dc93c5](https://www.github.com/googleapis/java-bigtable/commit/9dc93c5c9372f1501006e2d3a3a7affecd65fb8e))
* remove stats from javadoc ([googleapis#1108](https://www.github.com/googleapis/java-bigtable/issues/1108)) ([33fe7fe](https://www.github.com/googleapis/java-bigtable/commit/33fe7fe162cf84339e1887b052e446ef0aaf19d6))
* remove tracking latency from channel priming requests ([googleapis#1082](https://www.github.com/googleapis/java-bigtable/issues/1082)) ([bd873bc](https://www.github.com/googleapis/java-bigtable/commit/bd873bc82f0b210312fd442678c801758291935e))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants