From d0d1aa3195c0d63242254eece3e92e9ad078069b Mon Sep 17 00:00:00 2001 From: Billy Jacobson Date: Tue, 22 Jun 2021 10:50:02 -0400 Subject: [PATCH] docs: fix connection pool size for samples (#880) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes # ☕️ --- .../main/java/com/example/bigtable/ConfigureConnectionPool.java | 2 +- .../java/com/example/bigtable/ConfigureConnectionPoolTest.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/samples/snippets/src/main/java/com/example/bigtable/ConfigureConnectionPool.java b/samples/snippets/src/main/java/com/example/bigtable/ConfigureConnectionPool.java index b183fe7c0..e1534a3b2 100644 --- a/samples/snippets/src/main/java/com/example/bigtable/ConfigureConnectionPool.java +++ b/samples/snippets/src/main/java/com/example/bigtable/ConfigureConnectionPool.java @@ -37,7 +37,7 @@ public static void configureConnectionPool(String projectId, String instanceId) settingsBuilder.stubSettings() .setTransportChannelProvider( EnhancedBigtableStubSettings.defaultGrpcTransportProviderBuilder() - .setPoolSize(250) + .setPoolSize(10) .build()); BigtableDataSettings settings = settingsBuilder.build(); diff --git a/samples/snippets/src/test/java/com/example/bigtable/ConfigureConnectionPoolTest.java b/samples/snippets/src/test/java/com/example/bigtable/ConfigureConnectionPoolTest.java index 81288c9dc..c1f3b0377 100644 --- a/samples/snippets/src/test/java/com/example/bigtable/ConfigureConnectionPoolTest.java +++ b/samples/snippets/src/test/java/com/example/bigtable/ConfigureConnectionPoolTest.java @@ -41,6 +41,6 @@ public void testConfigureConnectionPool() { ConfigureConnectionPool.configureConnectionPool(projectId, instanceId); String output = bout.toString(); - assertThat(output, CoreMatchers.containsString("Connected with pool size of 250")); + assertThat(output, CoreMatchers.containsString("Connected with pool size of 10")); } }