diff --git a/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java b/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java index d8b3eda0a8..08eeb4c49c 100644 --- a/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java +++ b/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java @@ -395,9 +395,20 @@ public Map extract(ReadRowsRequest readRowsRequest) { } /** - * @param rowAdapter - * @param - * @return + * Creates a callable chain to handle bulk ReadRows RPCs. This is meant to be used in ReadRows + * batcher. The chain will: + * + * */ private UnaryCallable> createBulkReadRowsCallable( RowAdapter rowAdapter) { @@ -409,6 +420,8 @@ private UnaryCallable> createBulkReadRowsCallable( SpanName span = getSpanName("ReadRows"); + // TracedBatchingContextCallable needs to be the last in the callable chain so Batcher can pass + // a BatchedCallContext to add batching metrics to ApiTracer. UnaryCallable> traced = new TracedBatchedContextCallable<>( readRowsUserCallable.all(), @@ -540,7 +553,7 @@ private UnaryCallable createBulkMutateRowsCallable() { userFacing, settings.getHeaderTracer(), spanName.toString()); // TracedBatchingContextCallable needs to be the last in the callable chain so Batcher can pass - // batchingCallContext to add batching metrics to ApiTracer. + // a BatchedCallContext to add batching metrics to ApiTracer. UnaryCallable batchingContextCallable = new TracedBatchedContextCallable<>( withHeaderTracer,