From 22de64c7ec208641e7d866fc3cab6ecb614bac32 Mon Sep 17 00:00:00 2001 From: Mattie Fu Date: Thu, 9 Dec 2021 17:10:07 -0500 Subject: [PATCH] make the test more readable --- .../bigtable/misc_utilities/MethodComparator.java | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/misc_utilities/MethodComparator.java b/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/misc_utilities/MethodComparator.java index e593913cce..4c3ecd2744 100644 --- a/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/misc_utilities/MethodComparator.java +++ b/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/misc_utilities/MethodComparator.java @@ -31,12 +31,9 @@ public class MethodComparator { MethodComparator::compareMethods, "compare method names, parameters and return types"); private static boolean compareMethods(Method actual, Method expected) { - if (!actual.getName().equals(expected.getName()) - || !Arrays.equals(actual.getParameterTypes(), expected.getParameterTypes()) - || actual.getModifiers() != expected.getModifiers() - || !actual.getReturnType().equals(expected.getReturnType())) { - return false; - } - return true; + return actual.getName().equals(expected.getName()) + && Arrays.equals(actual.getParameterTypes(), expected.getParameterTypes()) + && actual.getModifiers() == expected.getModifiers() + && actual.getReturnType().equals(expected.getReturnType()); } }