Skip to content

Commit

Permalink
fix: fix maven test configs to make sure admin tests don't clobber da…
Browse files Browse the repository at this point in the history
…ta tests (#47)

* fix: fix maven test configs to make sure admin tests don't clobber data tests

* Update include patterns
  • Loading branch information
igorbernstein2 committed Oct 28, 2019
1 parent a16cb88 commit 18576f5
Showing 1 changed file with 10 additions and 6 deletions.
16 changes: 10 additions & 6 deletions google-cloud-bigtable/pom.xml
Expand Up @@ -206,8 +206,9 @@
<systemPropertyVariables>
<bigtable.env>emulator</bigtable.env>
</systemPropertyVariables>
<test>com.google.cloud.bigtable.data.v2.it.**</test>
<test>com.google.cloud.bigtable.admin.v2.it.**</test>
<includes>
<include>com.google.cloud.bigtable.**.it.*IT</include>
</includes>
<summaryFile>${project.build.directory}/failsafe-reports/failsafe-summary-emulator-it.xml</summaryFile>
</configuration>
</execution>
Expand All @@ -234,8 +235,9 @@
<systemPropertyVariables>
<bigtable.env>prod</bigtable.env>
</systemPropertyVariables>
<test>com.google.cloud.bigtable.data.v2.it.**</test>
<test>com.google.cloud.bigtable.admin.v2.it.**</test>
<includes>
<include>com.google.cloud.bigtable.**.it.*IT</include>
</includes>
<summaryFile>${project.build.directory}/failsafe-reports/failsafe-summary-prod-it.xml</summaryFile>
</configuration>
</execution>
Expand Down Expand Up @@ -268,8 +270,10 @@
<environmentVariables>
<GOOGLE_CLOUD_ENABLE_DIRECT_PATH>bigtable</GOOGLE_CLOUD_ENABLE_DIRECT_PATH>
</environmentVariables>
<!-- TODO(igorbernstein): Once the control plane is accessible via directpath, add admin tests -->
<test>com.google.cloud.bigtable.data.v2.it.**</test>
<includes>
<!-- TODO(igorbernstein): Once the control plane is accessible via directpath, add admin tests -->
<include>com.google.cloud.bigtable.data.v2.it.*IT</include>
</includes>
<summaryFile>${project.build.directory}/failsafe-reports/failsafe-summary-directpath-it.xml</summaryFile>
</configuration>
</execution>
Expand Down

0 comments on commit 18576f5

Please sign in to comment.