From b6d683e15cf9d274d9909e8843f0b823389fade7 Mon Sep 17 00:00:00 2001 From: Tianzi Cai Date: Tue, 29 Jun 2021 09:28:27 -0700 Subject: [PATCH 1/3] samples: correct non-existent url --- .../java/com/example/bigquerystorage/WriteToDefaultStream.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/snippets/src/main/java/com/example/bigquerystorage/WriteToDefaultStream.java b/samples/snippets/src/main/java/com/example/bigquerystorage/WriteToDefaultStream.java index 028e1c037c..b85edd38bb 100644 --- a/samples/snippets/src/main/java/com/example/bigquerystorage/WriteToDefaultStream.java +++ b/samples/snippets/src/main/java/com/example/bigquerystorage/WriteToDefaultStream.java @@ -52,7 +52,7 @@ public static void writeToDefaultStream(String projectId, String datasetName, St // Use the JSON stream writer to send records in JSON format. // For more information about JsonStreamWriter, see: - // https://googleapis.dev/java/google-cloud-bigquerystorage/latest/com/google/cloud/bigquery/storage/v1beta2/JstreamWriter.html + // https://googleapis.dev/java/google-cloud-bigquerystorage/latest/com/google/cloud/bigquery/storage/v1beta2/JsonStreamWriter.html try (JsonStreamWriter writer = JsonStreamWriter.newBuilder(parentTable.toString(), schema).build()) { // Append 10 JSON objects to the stream. From 63d50df373f092bca1e428ed260200e80e16fac7 Mon Sep 17 00:00:00 2001 From: Tianzi Cai Date: Tue, 29 Jun 2021 09:37:53 -0700 Subject: [PATCH 2/3] docs: user-provided streamOrTableName does not end with _default --- .../cloud/bigquery/storage/v1beta2/JsonStreamWriter.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/JsonStreamWriter.java b/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/JsonStreamWriter.java index 4cceeda16d..d4aba52362 100644 --- a/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/JsonStreamWriter.java +++ b/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/JsonStreamWriter.java @@ -183,9 +183,8 @@ private void setStreamWriterSettings( * StreamWriter by default. * * @param streamOrTableName name of the stream that must follow - * "projects/[^/]+/datasets/[^/]+/tables/[^/]+/streams/[^/]+" or if it is default stream - * (createDefaultStream is true on builder), then the name here should be a table name - * ""projects/[^/]+/datasets/[^/]+/tables/[^/]+" + * "projects/[^/]+/datasets/[^/]+/tables/[^/]+/streams/[^/]+" or + * table name "projects/[^/]+/datasets/[^/]+/tables/[^/]+" * @param tableSchema The schema of the table when the stream was created, which is passed back * through {@code WriteStream} * @return Builder @@ -260,7 +259,7 @@ public static final class Builder { * * @param streamOrTableName name of the stream that must follow * "projects/[^/]+/datasets/[^/]+/tables/[^/]+/streams/[^/]+" or - * "projects/[^/]+/datasets/[^/]+/tables/[^/]+/_default" + * "projects/[^/]+/datasets/[^/]+/tables/[^/]+" * @param tableSchema schema used to convert Json to proto messages. * @param client */ From c5153ff073da956fce24136e57861c97e53cdffd Mon Sep 17 00:00:00 2001 From: Tianzi Cai Date: Tue, 29 Jun 2021 09:53:48 -0700 Subject: [PATCH 3/3] lint --- .../cloud/bigquery/storage/v1beta2/JsonStreamWriter.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/JsonStreamWriter.java b/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/JsonStreamWriter.java index d4aba52362..2b2e531174 100644 --- a/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/JsonStreamWriter.java +++ b/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/JsonStreamWriter.java @@ -183,8 +183,8 @@ private void setStreamWriterSettings( * StreamWriter by default. * * @param streamOrTableName name of the stream that must follow - * "projects/[^/]+/datasets/[^/]+/tables/[^/]+/streams/[^/]+" or - * table name "projects/[^/]+/datasets/[^/]+/tables/[^/]+" + * "projects/[^/]+/datasets/[^/]+/tables/[^/]+/streams/[^/]+" or table name + * "projects/[^/]+/datasets/[^/]+/tables/[^/]+" * @param tableSchema The schema of the table when the stream was created, which is passed back * through {@code WriteStream} * @return Builder