Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: StreamWriterV2 sets exception for response with error #884

Merged
merged 1 commit into from Feb 25, 2021
Merged

feat: StreamWriterV2 sets exception for response with error #884

merged 1 commit into from Feb 25, 2021

Conversation

yayi-google
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yayi-google yayi-google requested review from a team and steffnay February 25, 2021 00:55
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 25, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Feb 25, 2021
@yayi-google yayi-google requested review from yirutang and removed request for steffnay February 25, 2021 00:55
@codecov
Copy link

codecov bot commented Feb 25, 2021 •
edited

Codecov Report

Merging #884 (5807dbf) into master (8e2ab01) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #884      +/-   ##
============================================
+ Coverage     80.85%   80.87%   +0.02%     
- Complexity     1014     1015       +1     
============================================
  Files            76       76              
  Lines          5500     5506       +6     
  Branches        423      424       +1     
============================================
+ Hits           4447     4453       +6     
  Misses          880      880              
  Partials        173      173
Impacted Files Coverage Δ Complexity Δ
...cloud/bigquery/storage/v1beta2/StreamWriterV2.java 95.89% <100.00%> (+0.13%) 33.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e2ab01...5807dbf. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 4677d7b into master Feb 25, 2021
@stephaniewang526 stephaniewang526 deleted the exception-on-error branch February 25, 2021 14:15
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 25, 2021
@release-please
chore(master): release 1.12.0 (#886)
8bcfcad 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.12.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.11.0...v1.12.0) (2021-02-25)


### Features

* StreamWriterV2 sets exception for response with error ([#884](https://www.github.com/googleapis/java-bigquerystorage/issues/884)) ([4677d7b](https://www.github.com/googleapis/java-bigquerystorage/commit/4677d7bd56db6c76106daeb7be38fa65f1c9c745))


### Documentation

* **sample:** Update parallel append sample to use StreamWriterV2 ([#883](https://www.github.com/googleapis/java-bigquerystorage/issues/883)) ([5c5c690](https://www.github.com/googleapis/java-bigquerystorage/commit/5c5c690fe39b3055596712dbd39064aed0b023da))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-shared-dependen…
c08f115 
…cies to v2.10.0 (googleapis#884)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-shared-dependencies](https://togithub.com/googleapis/java-shared-dependencies) | `2.9.0` -> `2.10.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.10.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.10.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.10.0/compatibility-slim/2.9.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.10.0/confidence-slim/2.9.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-shared-dependencies</summary>

### [`v2.10.0`](https://togithub.com/googleapis/java-shared-dependencies/blob/HEAD/CHANGELOG.md#&#8203;2100-httpsgithubcomgoogleapisjava-shared-dependenciescomparev290v2100-2022-04-15)

[Compare Source](https://togithub.com/googleapis/java-shared-dependencies/compare/v2.9.0...v2.10.0)

##### Dependencies

-   google-cloud-core 2.6.0 ([#&#8203;668](https://togithub.com/googleapis/java-shared-dependencies/issues/668)) ([22f4d18](https://togithub.com/googleapis/java-shared-dependencies/commit/22f4d1809cbb9848174b3569ab527e4bef00d443))
-   reverting protobuf to 3.19.4 ([#&#8203;657](https://togithub.com/googleapis/java-shared-dependencies/issues/657)) ([8501e6d](https://togithub.com/googleapis/java-shared-dependencies/commit/8501e6d842c10d2370bbd5d5246070134336bddd))
-   update dependency com.fasterxml.jackson:jackson-bom to v2.13.2.20220328 ([#&#8203;646](https://togithub.com/googleapis/java-shared-dependencies/issues/646)) ([7bfd6d7](https://togithub.com/googleapis/java-shared-dependencies/commit/7bfd6d7073859d1955b91b368c6713a72ffa14b6))
-   update dependency com.google.api-client:google-api-client-bom to v1.34.0 ([#&#8203;662](https://togithub.com/googleapis/java-shared-dependencies/issues/662)) ([1b8e378](https://togithub.com/googleapis/java-shared-dependencies/commit/1b8e378fe0ccf2a28c759868caaf5ba593a95728))
-   update dependency com.google.errorprone:error_prone_annotations to v2.12.1 ([#&#8203;652](https://togithub.com/googleapis/java-shared-dependencies/issues/652)) ([1cc80ee](https://togithub.com/googleapis/java-shared-dependencies/commit/1cc80ee984ebcad9bc2a95e2f28c0a49fe924b37))
-   update dependency com.google.errorprone:error_prone_annotations to v2.13.0 ([#&#8203;669](https://togithub.com/googleapis/java-shared-dependencies/issues/669)) ([61b7834](https://togithub.com/googleapis/java-shared-dependencies/commit/61b78341b34a251722be4805a6bdd895cd64836c))
-   update dependency com.google.http-client:google-http-client-bom to v1.41.6 ([#&#8203;654](https://togithub.com/googleapis/java-shared-dependencies/issues/654)) ([140ef40](https://togithub.com/googleapis/java-shared-dependencies/commit/140ef405bc17ed83f5ce177df59affca14fbe49c))
-   update dependency com.google.http-client:google-http-client-bom to v1.41.7 ([#&#8203;658](https://togithub.com/googleapis/java-shared-dependencies/issues/658)) ([f6f93e5](https://togithub.com/googleapis/java-shared-dependencies/commit/f6f93e5b9172c9684623c4c148e4a8fe2fae1e94))
-   update dependency com.google.oauth-client:google-oauth-client-bom to v1.33.2 ([#&#8203;655](https://togithub.com/googleapis/java-shared-dependencies/issues/655)) ([20cd9ed](https://togithub.com/googleapis/java-shared-dependencies/commit/20cd9eda112c96836a5ab7485a4247ed2bc0edb8))
-   update dependency com.google.oauth-client:google-oauth-client-bom to v1.33.3 ([#&#8203;663](https://togithub.com/googleapis/java-shared-dependencies/issues/663)) ([f011a46](https://togithub.com/googleapis/java-shared-dependencies/commit/f011a46c551dba16851b4f8c919c40452fc5d5c3))
-   update dependency com.google.protobuf:protobuf-bom to v3.20.0 ([#&#8203;651](https://togithub.com/googleapis/java-shared-dependencies/issues/651)) ([ad2ff73](https://togithub.com/googleapis/java-shared-dependencies/commit/ad2ff73207dd6493321c77d8eca0022baf13b4ce))
-   update dependency io.grpc:grpc-bom to v1.45.1 ([#&#8203;647](https://togithub.com/googleapis/java-shared-dependencies/issues/647)) ([38e46fc](https://togithub.com/googleapis/java-shared-dependencies/commit/38e46fc4f03af0a02f30ce4a2fa222c71797ae15))
-   update dependency org.checkerframework:checker-qual to v3.21.4 ([#&#8203;650](https://togithub.com/googleapis/java-shared-dependencies/issues/650)) ([125e80a](https://togithub.com/googleapis/java-shared-dependencies/commit/125e80ab2c3225a00c03f5ff5de94872ebb94303))
-   update gax.version to v2.15.0 ([#&#8203;649](https://togithub.com/googleapis/java-shared-dependencies/issues/649)) ([c7f32a6](https://togithub.com/googleapis/java-shared-dependencies/commit/c7f32a68b14520104432282ac9598643700162eb))
-   update gax.version to v2.16.0 ([#&#8203;664](https://togithub.com/googleapis/java-shared-dependencies/issues/664)) ([caaf941](https://togithub.com/googleapis/java-shared-dependencies/commit/caaf941643af04295f5527a0144587d7bf040862))
-   update google.common-protos.version to v2.8.1 ([#&#8203;656](https://togithub.com/googleapis/java-shared-dependencies/issues/656)) ([df4a4a2](https://togithub.com/googleapis/java-shared-dependencies/commit/df4a4a2130a3cdb2965ea42962d1ea6a85506ba7))
-   update google.common-protos.version to v2.8.2 ([#&#8203;659](https://togithub.com/googleapis/java-shared-dependencies/issues/659)) ([b499e2b](https://togithub.com/googleapis/java-shared-dependencies/commit/b499e2bc99506d48d26e35bf6e68c09409ce8b11))
-   update google.common-protos.version to v2.8.3 ([#&#8203;660](https://togithub.com/googleapis/java-shared-dependencies/issues/660)) ([461081c](https://togithub.com/googleapis/java-shared-dependencies/commit/461081c0cf73057c1f6e07fc573453ad467a60ae))
-   update iam.version to v1.3.0 ([#&#8203;648](https://togithub.com/googleapis/java-shared-dependencies/issues/648)) ([6670c4f](https://togithub.com/googleapis/java-shared-dependencies/commit/6670c4f61fcf075c543bfd148eea49796e0662ce))
-   update iam.version to v1.3.1 ([#&#8203;661](https://togithub.com/googleapis/java-shared-dependencies/issues/661)) ([cc8fbe6](https://togithub.com/googleapis/java-shared-dependencies/commit/cc8fbe6eae03341c2ece7d3356febc843a74a812))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-storage-nio).
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
@release-please
chore(main): release 0.123.28 (googleapis#879)
29707f5 
🤖 I have created a release *beep* *boop*
---


### [0.123.28](googleapis/java-storage-nio@v0.123.27...v0.123.28) (2022-04-18)


### Bug Fixes

* **native:** initialize classes at build-time to fix Native Image compilation ([googleapis#874](googleapis/java-storage-nio#874)) ([df905cb](googleapis/java-storage-nio@df905cb))
* **test:** replace HashMap with ConcurrentHashMap to avoid ConcurrentModificatio… ([googleapis#883](googleapis/java-storage-nio#883)) ([d2fe2a0](googleapis/java-storage-nio@d2fe2a0))


### Dependencies

* update dependency com.google.apis:google-api-services-storage to v1-rev20220401-1.32.1 ([googleapis#881](googleapis/java-storage-nio#881)) ([a598199](googleapis/java-storage-nio@a598199))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.10.0 ([googleapis#884](googleapis/java-storage-nio#884)) ([c08f115](googleapis/java-storage-nio@c08f115))
* update dependency com.google.cloud:google-cloud-storage to v2.6.0 ([googleapis#878](googleapis/java-storage-nio#878)) ([0bd1985](googleapis/java-storage-nio@0bd1985))
* update dependency com.google.cloud:google-cloud-storage to v2.6.1 ([googleapis#885](googleapis/java-storage-nio#885)) ([cf24525](googleapis/java-storage-nio@cf24525))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

@yirutang yirutang yirutang approved these changes

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yayi-google @stephaniewang526 @yirutang